Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PathUtils recognize query and splat values containing newlines #1166

Closed
wants to merge 1 commit into from
Closed

Make PathUtils recognize query and splat values containing newlines #1166

wants to merge 1 commit into from

Conversation

motiz88
Copy link
Contributor

@motiz88 motiz88 commented May 7, 2015

Fixes #1099. Tests included.

@ryanflorence
Copy link
Member

thanks @motiz88, sorry for moving so much code around recently, mind updating this to latest master?

@mjackson
Copy link
Member

I manually merged this work (and added back a bunch of tests that had been deleted in the refactor) in 4759961.

@mjackson mjackson closed this Jun 19, 2015
@mjackson mjackson mentioned this pull request Jun 19, 2015
Closed
@taion taion mentioned this pull request Mar 21, 2016
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL with percent-encoded characters breaks router
3 participants
@motiz88 @ryanflorence @mjackson