Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗺 Loader+Action Context (Middleware) #9566

Closed
1 of 2 tasks
ryanflorence opened this issue Nov 7, 2022 · 7 comments
Closed
1 of 2 tasks

🗺 Loader+Action Context (Middleware) #9566

ryanflorence opened this issue Nov 7, 2022 · 7 comments
Assignees

Comments

@ryanflorence
Copy link
Member

ryanflorence commented Nov 7, 2022

Progress

@tigerabrodi
Copy link

This is exciting! 🔥

@kentcdodds
Copy link
Member

This will be super helpful so I can ditch express and just rely on remix-serve 🔥

My specific use case includes auth (of course), but also I'm working on implementing this: https://fly.io/docs/litefs/files/#using-txid-to-handle-consistency

So, basically, when a user makes a mutation in a non-primary region, I need to force them to wait until that data has been propagated to their region before they can read their local db.

Things get kinda funny when you distribute your data, but want to make sure there's consistency as well as availability & partition tolerance (pick two, add one 😅).

@tigerabrodi
Copy link

Nice! 😄

Our use case also includes auth, getting the user through the context, in both the actions and loaders. 🔥

@AMoktar
Copy link

AMoktar commented Nov 16, 2022

Thanks guys, you are the best 👍

@runarj
Copy link

runarj commented Nov 18, 2022

Great work!

I am unsure if this is relevant, but how will beforeLoader traverse the route hierarchy? If you, for example, choose a "Pre-order Traversal," are you sure it will fit all future uses of the hook?

Also, would it be better to add this as a plugin so that projects could add additional hooks themselves? I guess that this will make things too complicated, but I could be wrong.

@remix-run remix-run deleted a comment from AMoktar Nov 18, 2022
@remix-run remix-run deleted a comment from AMoktar Nov 18, 2022
@remix-run remix-run locked as off-topic and limited conversation to collaborators Nov 30, 2022
@ryanflorence ryanflorence moved this from Planned to In Progress in Roadmap Dec 20, 2022
@ryanflorence ryanflorence moved this from In Progress to Planned in Roadmap Jan 3, 2023
@brophdawg11 brophdawg11 moved this from Planned to In Progress in Roadmap Jan 18, 2023
@ryanflorence
Copy link
Member Author

@jacob-ebey and @brophdawg11 to try to wrap up the adapter/bundling questions, then bring in @ryanflorence and @mjackson for an API review

@ryanflorence ryanflorence moved this from In Progress to Planned in Roadmap Mar 7, 2023
@brophdawg11
Copy link
Contributor

Closing this temporarily since we put this on hold while we finalize Remix v2. This is early on the roadmap once v2 is out so will re-open then.

@github-project-automation github-project-automation bot moved this from Planned to Merged in Roadmap Apr 27, 2023
@MichaelDeBoey MichaelDeBoey moved this from Merged to Backlog in Roadmap Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

7 participants