Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small mistake in Redux Integration documentation #7019

Closed
canibanoglu opened this issue Nov 7, 2019 · 2 comments
Closed

Small mistake in Redux Integration documentation #7019

canibanoglu opened this issue Nov 7, 2019 · 2 comments

Comments

@canibanoglu
Copy link

Version

v5.1.2

This is actually a small mistake in the documentation that I came across. In packages/react-router/docs/guides/redux.md it is mentioned that redux implements shouldComponentUpdate but this is not true, it is react-redux that "implements" this. That in itself is a bit leading because as far as I can see react-redux doesn't implement this but rather mimics it to force an update if there is a change to the current context's store state.

Relevant section:

The problem is that Redux implements shouldComponentUpdate and there's no indication that anything has changed if it isn't receiving props from the router.

Probably something like The problem is that as far as redux and react-redux is concerned that there haven't been any changes to the store.

I'd be happy to submit a PR when we agree on a wording for this. Splitting hairs, but still :)

@timdorr
Copy link
Member

timdorr commented Nov 7, 2019

We actually don't do that anymore. The correct change is to just to remove it entirely!

@timdorr timdorr closed this as completed in ef60b08 Nov 7, 2019
@canibanoglu
Copy link
Author

Or that :)

@lock lock bot locked as resolved and limited conversation to collaborators Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants