Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link with parenthesis does not get Active class #5641

Closed
OllieJennings opened this issue Oct 19, 2017 · 1 comment
Closed

Link with parenthesis does not get Active class #5641

OllieJennings opened this issue Oct 19, 2017 · 1 comment

Comments

@OllieJennings
Copy link

OllieJennings commented Oct 19, 2017

Hi so this is more of a question.

When a url contains a parenthesis such as: https://hydal.xyz/pricewatch/027357/intel-core-i7-7820x-(boxed)

A link element <NavLink to="/pricewatch/027357/intel-core-i7-7820x-(boxed)">link</NavLink> will not be active, when on this page.

Is there anyway to make it active? would you have to use the exact prop to do this?

FYI using versions:

"react-router": "^4.2.0",
"react-router-dom": "^4.2.2",
@pshrmn
Copy link
Contributor

pshrmn commented Oct 19, 2017

#5596 fixes this (but has not been released yet). If you need this in the short term, I would probably copy that code into it's own module in your project (you just need to fix the imports).

@pshrmn pshrmn closed this as completed Oct 19, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants