Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceError when using anything having to do with query arguments #254

Closed
johnthedebs opened this issue Aug 31, 2014 · 6 comments
Closed

Comments

@johnthedebs
Copy link

I'm getting a ReferenceError for the variable Buffer when either visiting a URL with any query arguments or adding a query attribute to a Link. Forgive me if I'm missing a dependency or something; I couldn't figure out why it was failing exactly and found no mention of anyone else having a similar problem.

I'm using react (with add-ons) version 0.11.1 and react-router version 0.6.1 (this also occurred with 0.6.0). I tried using Chrome 37 and Safari 8.0 beta.

Let me know if there's any other info that would be helpful!

@ryanflorence
Copy link
Member

Can you post the full error and any code around it?

Sent from my iPhone

On Aug 30, 2014, at 11:37 PM, John Debs [email protected] wrote:

I'm getting a ReferenceError for the variable Buffer when either visiting a URL with any query arguments or adding a query attribute to a Link. Forgive me if I'm missing a dependency or something; I couldn't figure out why it was failing exactly and found no mention of anyone else having a similar problem.

I'm using react (with add-ons) version 0.11.1 and react-router version 0.6.1 (this also occurred with 0.6.0). I tried using Chrome 37 and Safari 8.0 beta.

Let me know if there's any other info that would be helpful!


Reply to this email directly or view it on GitHub.

@johnthedebs
Copy link
Author

https://gist.github.com/johnthedebs/d25dc5a46b8411cfe016

That's what I've got, and I'm visiting (and getting the first stack trace below for) /items/search/?test=test, while /items/search/ works as expected. Creating a Link with the attribute query={{test: "test"}} in another component causes a similar error with a different stack trace (the bottom one).

screen shot 2014-08-31 at 6 43 07 pm

screen shot 2014-08-31 at 6 51 31 pm

@johnthedebs
Copy link
Author

Let me know if there's a better way to copy those errors in... I haven't needed to share full JS stack traces before.

@ryanflorence
Copy link
Member

Can you identify which part of the code is looking for "Buffer"?

Sent from my iPhone

On Aug 31, 2014, at 4:56 PM, John Debs [email protected] wrote:

Let me know if there's a better way to copy those errors in... I haven't needed to share full JS stack traces before.


Reply to this email directly or view it on GitHub.

@ryanflorence
Copy link
Member

Also, are you using the global build or the cjs modules?

@mjackson
Copy link
Member

mjackson commented Sep 1, 2014

I'm pretty sure it's the qs package. I fixed it here. Looks like we just need to update the dep to at least 2.2.0.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants