Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Page goes blank when clicking header #12930

Closed
elldritch opened this issue Jan 31, 2025 · 3 comments
Closed

[Docs]: Page goes blank when clicking header #12930

elldritch opened this issue Jan 31, 2025 · 3 comments
Labels

Comments

@elldritch
Copy link

Describe what's incorrect/missing in the documentation

Clicking on any subheader in a documentation page makes the whole page go blank. This problem goes away if I refresh or hit 'back'. I've confirmed through the DevTools that the elements themselves are actually disappearing, this is not just a visual rendering bug.

To reproduce:

  1. Go to https://reactrouter.com/7.1.5/start/framework/route-module
  2. Click any of the header links under "On this page" to the right

Here's a loom of it happening to me: https://www.loom.com/share/519300e538934fb595dcf2ca821b7787?sid=2c92f9c3-b673-47da-9098-2712a8586835

I am running Chrome 132 on Arch Linux.

@elldritch elldritch added the docs label Jan 31, 2025
@timdorr
Copy link
Member

timdorr commented Feb 1, 2025

@brophdawg11 Is this possibly a follow-on regression from #12927?

@brophdawg11
Copy link
Contributor

Hm - I wonder if this is locally cached assets? I was just able to reproduce too, which surprised me because the website should be on 7.1.3 (the bug was introduced in 7.1.4 and fixed in 7.1.5). I did a full cache clear in Chrome and reloaded and now I can't reproduce.

@elldritch If this is still happening for you, could you look at the network tab and let me know the files you're seeing loaded? For example:

Image

Then inside the "chunk" file towards the top of the network tab, you could look for the react router version comment:

Image

Please let me know what you are seeing and if a full cache clear fixes it for you. I usually do this by loading the site, then going to Dev Tools > Application Tab > Storage > Clear Site Data but it may also work with just a Shift-F5 reload.

If this is happening for you on 7.1.3 or 7.1.5 then we would have a separate bug to look into, but if you have a 7.1.4 cached version then that would explain it. I'll look into our caching setup there too

@brookslybrand
Copy link
Contributor

@elldritch thanks for opening this ticket, @brophdawg11 was right, the assets cache wasn't busted

Sorry about that! Everything should be working properly now and there seems to be no regression in react-router itself.

Hopefully we've squashed the issue that cached this bad caching, but if you do ever notice issues on our website again, please open an in issue in the react-router-website repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants