From a579835e1f4d6a41604480c4da22ce932884a49c Mon Sep 17 00:00:00 2001 From: Logan McAnsh Date: Thu, 2 Feb 2023 15:54:02 -0500 Subject: [PATCH] ci: uppercase ENV, changesets output is camelCase (#10036) Signed-off-by: Logan McAnsh --- .github/workflows/release.yml | 8 ++++---- scripts/release/find-release-from-changeset.js | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 95ddf52d6b..d3554fdbf0 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -15,7 +15,7 @@ jobs: if: github.repository == 'remix-run/react-router' runs-on: ubuntu-latest outputs: - published_packages: ${{ steps.changesets.outputs.published_packages }} + published_packages: ${{ steps.changesets.outputs.publishedPackages }} published: ${{ steps.changesets.outputs.published }} steps: - name: 🛑 Cancel Previous Runs @@ -83,8 +83,8 @@ jobs: package_version=$(node ./scripts/release/find-release-from-changeset.js) echo "package_version=${package_version}" >> $GITHUB_OUTPUT env: - package_version_to_follow: "react-router" - published_packages: ${{ needs.release.outputs.published_packages }} + PACKAGE_VERSION_TO_FOLLOW: "react-router" + PUBLISHED_PACKAGES: ${{ needs.release.outputs.published_packages }} comment: name: 📝 Comment on related issues and pull requests @@ -92,6 +92,6 @@ jobs: needs: [release, find_package_version] uses: ./.github/workflows/release-comments.yml with: - ref: refs/tags/remix@${{ needs.find_package_version.outputs.packageVersion }} + ref: refs/tags/react-router@${{ needs.find_package_version.outputs.packageVersion }} package_version_to_follow: "react-router" release_branch: ${{ github.ref_name }} diff --git a/scripts/release/find-release-from-changeset.js b/scripts/release/find-release-from-changeset.js index 57fd0e6efb..a499ec59e2 100644 --- a/scripts/release/find-release-from-changeset.js +++ b/scripts/release/find-release-from-changeset.js @@ -32,6 +32,6 @@ function findReleaseFromChangeset(publishedPackages, packageVersionToFollow) { } findReleaseFromChangeset( - process.env.published_packages, - process.env.package_version_to_follow + process.env.PUBLISHED_PACKAGES, + process.env.PACKAGE_VERSION_TO_FOLLOW );