-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Amazon ECR #703
Comments
FWIW, I took a stab at this today: wowgroup/empire@14bee7db. I'll open a PR once I've given it another look-over (tomorrow morning by my estimates). |
@protomouse awesome stuff. If you wanna open a PR, I'd love to get this merged in for the next release. |
PR done. |
@ejholmes @protomouse how can we use ECR with EMPIRE ? |
#730 was just merged and will be in the next release. @JacopoDaeli The only thing you should need to do is add the following permissions to your EC2 container instances instance profile:
|
How we pass a docker.AuthConfiguration down for pulls should be abstract a bit so that we can generate a docker.AuthConfiguration dynamically to work with ECR, and we can provide various AuthConfigurationProvider implementations:
The text was updated successfully, but these errors were encountered: