Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Amazon ECR #703

Closed
ejholmes opened this issue Dec 22, 2015 · 5 comments
Closed

Add support for Amazon ECR #703

ejholmes opened this issue Dec 22, 2015 · 5 comments

Comments

@ejholmes
Copy link
Contributor

How we pass a docker.AuthConfiguration down for pulls should be abstract a bit so that we can generate a docker.AuthConfiguration dynamically to work with ECR, and we can provide various AuthConfigurationProvider implementations:

// Generates a docker.AuthConfiguration from a .dockercfg
FileProvider(file io.Reader) docker.AuthConfiguration {}
// Generates a docker.AuthConfiguration for an Amazon ECR registry.
ECRProvider() docker.AuthConfiguration {}
// Merges multiple docker.AuthConfigurations together.
MultiProvider(providers ...AuthConfigurationProvider) AuthConfigurationProvider
@m87h
Copy link
Contributor

m87h commented Jan 13, 2016

FWIW, I took a stab at this today: wowgroup/empire@14bee7db. I'll open a PR once I've given it another look-over (tomorrow morning by my estimates).

@ejholmes
Copy link
Contributor Author

@protomouse awesome stuff. If you wanna open a PR, I'd love to get this merged in for the next release.

@m87h m87h mentioned this issue Jan 14, 2016
@m87h
Copy link
Contributor

m87h commented Jan 14, 2016

PR done.

@JacopoDaeli
Copy link

@ejholmes @protomouse how can we use ECR with EMPIRE ?

@ejholmes
Copy link
Contributor Author

#730 was just merged and will be in the next release.

@JacopoDaeli The only thing you should need to do is add the following permissions to your EC2 container instances instance profile:

ecr:GetAuthorizationToken
ecr:BatchCheckLayerAvailability
ecr:GetDownloadUrlForLayer
ecr:BatchGetImage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants