Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent release contain faulty changelog links #323

Closed
4 tasks done
jrfnl opened this issue Jan 27, 2025 · 4 comments
Closed
4 tasks done

Recent release contain faulty changelog links #323

jrfnl opened this issue Jan 27, 2025 · 4 comments
Labels
💪 phase/solved Post is done

Comments

@jrfnl
Copy link

jrfnl commented Jan 27, 2025

Initial checklist

Affected package

All recent releases

Steps to reproduce

All recent releases contain a "Full changelog" link which doesn't link to a usable "full changelog"...

Example: https://github.com/remarkjs/remark-lint/releases/tag/remark-lint-fenced-code-flag%404.1.0

image

The changelog link compares two different sub-packages, making the link not very informative...

An even better example are any of the later releases, like https://github.com/remarkjs/remark-lint/releases/tag/remark-lint-maximum-heading-length%404.1.0

image

... which results in the following code comparison which doesn't contain any reference to the change mentioned in the release notes:
image

Actual behavior

Changelog links do not show the changes since the last release of the subpackage.

Expected behavior

Changelog links which compare the latest release of a subpackage with the previous release of the same subpackage.

Runtime

No response

Package manager

No response

Operating system

No response

Build and bundle tools

No response

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jan 27, 2025
@wooorm
Copy link
Member

wooorm commented Jan 28, 2025

Hi!

I recommend looking at the rest of the changelog. That’s the relevant bit!

Those links in the footer are links that GH generates. I keep them in because that’s GH’s doing. But sure I will try and remember to remove them next time, as GH doesn’t generate good ones for monorepos.

@wooorm wooorm closed this as completed Jan 28, 2025

This comment has been minimized.

@wooorm wooorm added the 💪 phase/solved Post is done label Jan 28, 2025
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jan 28, 2025
@jrfnl
Copy link
Author

jrfnl commented Jan 28, 2025

Thanks for responding @wooorm. Understood, just wanted to raise some awareness of the confusion the links were causing.

@wooorm
Copy link
Member

wooorm commented Jan 28, 2025

It’s a good point; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

No branches or pull requests

2 participants