Replace HTML to DOM implementation with html-dom-parser package
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTML to DOM parser has been externalized to its own package. Save to dependencies: - [email protected] Remove from dependencies: - [email protected] - [email protected] Remove files: - lib/html-to-dom-server.js - lib/html-to-dom-client.js Update `index.js` to require `html-dom-parser`.
Fix broken requires in tests now that `lib/html-to-dom-server.js` and `lib/html-to-dom-client.js` have been deleted (use `html-dom-parser` instead). Remove HTML to DOM tests since `html-dom-parser` has its own tests. Remove `helpers.deepEqualCircular()` and its tests as it was used to test HTML to DOM parsing (which is no longer handled by this package, but `html-dom-parser`).
- Rename `test/data.json` to `test/helpers/mocks.json` - Require mocks in test helpers index - Add a test for doctype (should be skipped and not parsed) - Tidy tests
Replace `htmlparser2` with `html-dom-parser` link and tidy up other parts.
remarkablemark
added a commit
that referenced
this pull request
Oct 14, 2016
- Replace HTML to DOM implementation with `html-dom-parser` (#28) - Update dependencies - Save `html-dom-parser` - Remove `domhandler` and `htmlparser2` - Update tests - Remove unused tests and helpers - Update mocks - Add test for doctype - Throw `TypeError` instead of `Error` for invalid first argument - Update tests - README - Update "Special Thanks" section - Tidy where necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updating the package and tests now that the HTML to DOM logic has been externalized to html-dom-parser package.
Tasks:
html-dom-parserhtml-dom-parser@0.0.2domhandler@2.3.0htmlparser2@3.9.1lib/html-to-dom-server.jsandlib/html-to-dom-client.jsand requirehtml-dom-parserhtml-dom-parserwhere necessary