Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esm): fix any type #1317

Merged
merged 4 commits into from
Feb 16, 2024
Merged

fix(esm): fix any type #1317

merged 4 commits into from
Feb 16, 2024

Conversation

mrlika
Copy link
Contributor

@mrlika mrlika commented Feb 15, 2024

Fix any type of export:

image

What is the motivation for this pull request?

Import:

import HTMLReactParser from 'html-react-parser';

HTMLReactParser('');

Results in any typed HTMLReactParser reference that is disallowed by linters in many projects:

Unsafe call of an `any` typed value.eslint[@typescript-eslint/no-unsafe-call](https://typescript-eslint.io/rules/no-unsafe-call)

What is the current behavior?

The export is not typed (i.e. any).

What is the new behavior?

The export type is fixed to the expected one.

Checklist:

Copy link
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the lint error?

npm run lint:fix

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a749ac) 100.00% compared to head (5d6dd72) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1317   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          151       151           
  Branches        49        49           
=========================================
  Hits           151       151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remarkablemark remarkablemark changed the title Fix any type fix(esm): fix any type Feb 16, 2024
@remarkablemark remarkablemark merged commit 56549f1 into remarkablemark:master Feb 16, 2024
6 of 7 checks passed
@remarkablemark
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants