From a25f41ca608b85caba8f2517c81e88e4a0c246be Mon Sep 17 00:00:00 2001
From: Mark <mark@remarkablemark.org>
Date: Mon, 12 Feb 2024 16:38:15 -0500
Subject: [PATCH] fix(types): use `React.JSX` instead of the global `JSX`
 namespace

---
 __tests__/dom-to-react.test.tsx | 16 +++++++++-------
 src/dom-to-react.ts             |  1 +
 src/types.ts                    |  2 +-
 3 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/__tests__/dom-to-react.test.tsx b/__tests__/dom-to-react.test.tsx
index 8ec21bec..302cb274 100644
--- a/__tests__/dom-to-react.test.tsx
+++ b/__tests__/dom-to-react.test.tsx
@@ -30,7 +30,9 @@ describe('domToReact', () => {
   });
 
   it('converts multiple DOM nodes to React', () => {
-    const reactElements = domToReact(htmlToDOM(html.multiple)) as JSX.Element[];
+    const reactElements = domToReact(
+      htmlToDOM(html.multiple),
+    ) as React.JSX.Element[];
     reactElements.forEach((reactElement, index) => {
       expect(reactElement.key).toBe(String(index));
     });
@@ -83,7 +85,7 @@ describe('domToReact', () => {
   });
 
   it('does not have `children` for void elements', () => {
-    const reactElement = domToReact(htmlToDOM(html.img)) as JSX.Element;
+    const reactElement = domToReact(htmlToDOM(html.img)) as React.JSX.Element;
     expect(reactElement.props.children).toBe(undefined);
   });
 
@@ -97,7 +99,7 @@ describe('domToReact', () => {
   it('skips doctype and comments', () => {
     const reactElements = domToReact(
       htmlToDOM(html.doctype + html.single + html.comment + html.single),
-    ) as JSX.Element[];
+    ) as React.JSX.Element[];
     expect(reactElements).toHaveLength(2);
     expect(reactElements[0].key).toBe('1');
     expect(reactElements[1].key).toBe('3');
@@ -177,7 +179,7 @@ describe('replace option', () => {
     (value) => {
       const reactElement = domToReact(htmlToDOM('<br>'), {
         replace: () => value,
-      }) as JSX.Element;
+      }) as React.JSX.Element;
       expect(reactElement).toEqual(<br />);
     },
   );
@@ -185,7 +187,7 @@ describe('replace option', () => {
   it('does not set key for a single node', () => {
     const reactElement = domToReact(htmlToDOM(html.single), {
       replace: () => <div />,
-    }) as JSX.Element;
+    }) as React.JSX.Element;
     expect(reactElement.key).toBe(null);
   });
 
@@ -213,7 +215,7 @@ describe('replace option', () => {
           }
         },
       },
-    ) as JSX.Element[];
+    ) as React.JSX.Element[];
 
     expect(reactElements[0].key).toBe('0');
     expect(reactElements[1].key).toBe('myKey');
@@ -247,7 +249,7 @@ describe('transform option', () => {
       transform: (reactNode, domNode, index) => {
         return <div key={index}>{reactNode}</div>;
       },
-    }) as JSX.Element;
+    }) as React.JSX.Element;
 
     expect(reactElement.key).toBe('0');
     expect(reactElement.props.children.props.children[0].key).toBe('0');
diff --git a/src/dom-to-react.ts b/src/dom-to-react.ts
index 6e28a6bc..725e9342 100644
--- a/src/dom-to-react.ts
+++ b/src/dom-to-react.ts
@@ -1,4 +1,5 @@
 import { cloneElement, createElement, isValidElement } from 'react';
+import type { JSX } from 'react';
 import type { Element, DOMNode, Text } from 'html-dom-parser';
 
 import attributesToProps from './attributes-to-props';
diff --git a/src/types.ts b/src/types.ts
index 4c6c1e87..cfe696b9 100644
--- a/src/types.ts
+++ b/src/types.ts
@@ -1,7 +1,7 @@
 import type { DomHandlerOptions } from 'domhandler';
 import type { DOMNode } from 'html-dom-parser';
 import type { ParserOptions } from 'htmlparser2';
-import type { ReactNode } from 'react';
+import type { JSX, ReactNode } from 'react';
 
 export interface HTMLReactParserOptions {
   htmlparser2?: ParserOptions & DomHandlerOptions;