Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement workaround to make HSM keys work #21

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

gnarea
Copy link
Member

@gnarea gnarea commented Sep 20, 2023

We can't explicitly create key versions with Google KMS due to hashicorp/terraform-provider-google#13924, so this change lets the google_kms_crypto_key resource create an initial key and then we import it.

We can't explicitly create key versions with Google KMS due to hashicorp/terraform-provider-google#13924, so this change lets the `google_kms_crypto_key` resource create an initial key and then we import it.
@gnarea gnarea added the automerge Allow kodiak to automerge commit when all checks pass label Sep 20, 2023
@kodiakhq kodiakhq bot merged commit a60c6e8 into main Sep 20, 2023
6 checks passed
@kodiakhq kodiakhq bot deleted the hsm-support branch September 20, 2023 15:25
@github-actions
Copy link

🎉 This PR is included in version 1.8.15 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Allow kodiak to automerge commit when all checks pass released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant