Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update Internet GW default params and fix wrong identity certificate usage #732

Merged
merged 3 commits into from
Mar 6, 2024
Merged

fix: Update Internet GW default params and fix wrong identity certificate usage #732

merged 3 commits into from
Mar 6, 2024

Conversation

sdsantos
Copy link
Collaborator

gnarea
gnarea requested changes Feb 29, 2024
View reviewed changes
app/src/main/res/raw/public_gateway_cert.der Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to rename this to something like default_internet_gateway_params.der, as this is no longer a certificate.

app/src/main/java/tech/relaycorp/gateway/domain/LocalConfig.kt Outdated Show resolved Hide resolved
@sdsantos sdsantos force-pushed the update-internet-gw-params branch from 4108e1b to 193fe8c Compare March 4, 2024 18:57
@sdsantos
Copy link
Collaborator Author

sdsantos commented Mar 4, 2024

I've tested the Parcel delivery already. Just need to test the Cargo delivery still.

gnarea
gnarea approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@gnarea gnarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇🏾

@gnarea gnarea added the automerge Allow kodiak to automerge commit when all checks pass label Mar 6, 2024
@kodiakhq kodiakhq bot merged commit 4c65c39 into master Mar 6, 2024
7 checks passed
@kodiakhq kodiakhq bot deleted the update-internet-gw-params branch March 6, 2024 13:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

🎉 This PR is included in version 1.9.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnarea gnarea gnarea approved these changes

Assignees
No one assigned
Labels
automerge Allow kodiak to automerge commit when all checks pass released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdsantos @gnarea