Catch more case in error parser #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error parser's error when using persisted query
|
Thanks a lot! |
|
this PR broke some tests, see https://travis-ci.org/github/relay-tools/react-relay-network-modern/builds/716341245 |
|
What the hell? Why travis & github lost CI status... I accepted PR without seeing fallen tests. 🤬 @felippepuhle thanks for reporting 👍 @tranvansang can you fix broken tests in new PR? Tnx. 😉 |
|
I don't know exactly what's happening, but I think we'll need to manually specify the operation for each test, here for example |
|
Fixed in a9a036f |
|
🎉 This PR is included in version 4.7.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error parser's error when using persisted query