Add support for DMD 2.094 -preview=in switch #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow users to use -preview=in as soon as it's released. 'in ref' on string doesn't make much sense, so it was turned into a simple 'in'. 'Location' is a string + an 'int', and while that would be passed by ref with the new switch, there's not much point in ensuring ref here, as the difference is minimal, but prevents using rvalues, so it was also turned into a simple 'in'. Lastly, for node, it was changed to be simply 'const ref', so as to keep the 'ref'.
|
I don't know if you can review this too @wilzbach ? |
wilzbach
approved these changes
Aug 31, 2020
|
Review, but I don't have merge rights here. |
|
@s-ludwig : Any chance we could move this to the vibe.d org since it depends on it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@s-ludwig : Would be nice to have this in a release, as Vibe.d requires it (dlang/dmd#11632)