-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux Only Issue] Hook GetEntityInit #722
Comments
If I can insist about this request, ReHLDS definitively needs more API functions... The way all your API is designed is clean, but the fact you are against "memory hack the engine" and delivers an engine very not adapted for this is very bad/critical from my opinion. I'm not gonna waste my time and argue with you devs about that, you have your reasons, but at least, you could enhance the API to provide a workaround. The fact is, and especially due to this anti-mem hack problem, my opinion is that the ReHLDS's API is too weak (there are stuff, but a lot of them are more for your 3rd-party projects, or, a few others I even do not know what this does, I'll have to look into your sources). For example, I would like to see a new function, which exports the address of most of the "global variables" of the engine (as you did with the "GetAllowCheats", "GetCmdSource", etc. functions), you could make one via "enum" or "name", like "void* (*GetGlobalAddress)(const char *szName)" where we could pass as name, for example, "allow_cheats", "cvar_vars", "g_psvs", "g_psv", etc., the function will return the address (if(!strcmp(szName, "g_psvs")) return &g_psv..., etc.). I would like to have those "g_psvs" & "g_psv" global private vars exported, due to their high utility and the fact they deal with important structures that handle many things (as resources, etc.). I would like to see much more hooks (chains), as the "GetEntityInit" requested here, but also "ED_Free", which I really need for various upcoming features of my project. I know you've added a "PF_Remove" hook, but that's not the function ideal for my stuff (it's just the "RemoveEntity" func), I want the "one and only final one" which removes an entity (when FL_KILLME set, etc.). You may suggest me the "OnFreeEntPrivateData" from the API, well, for some reasons this one is not very good to match with my stuff, besides it's a middle-set notification like an event. So please add those both functions! |
Please add more API functions guys. |
Again (as recall for guys playing the dead...), please add more API functions guys. |
You can create a pull request if you want to add things you need to use. |
@eat1k He doesn't wanna to create PRs. It's just trolling. Nothing special. |
It is better if this comes directly from the rehlds devs, as they are more experienced. |
You are right, I do not want to create PRs, for multiple reasons. Firstly, I do not know how much how to use GitHub, and do not even care, I've just made an account for posting comments/requests, nothing more. Secondly, I do not think it's my job to do it, I'm not the one who started such project, and, when someone ask me a plugin request, I do not tell him "do your request yourself and code yourself the plugin"... I think, due to how important it is and how weak is the ReHLDS's API, a pinned topic to the top named like "[API] Requests of new functions & hook chains" could be created, where people perform their requests, and, sometimes, when devs can work on them, they do them like in "one shot", and people like me will be happy to see that. Seriously, is it so much asking? ReHLDS is in overall, interesting, with a bunch of bug fixes, new features, etc., but about programming possibilities, despite there is an API, I consider it as the worst & weak engine for HL1 games. Maybe a lot of people do not care at all about API functions, because there are just lambda users who do not know about, and so not directly concerned, or, maybe some other people can find their need with that you purpose inside, but well, for an addon/plugins developer like me, this engine just put sticks in my wheels by making my life harder, also making me waste much time to adapt the upcoming things I'm developping with it, or just make not possible at all. It's not I like to negatively criticize, no I usually do not, and it's not in my nature to do that, because I respect others's people, but when I try asking nicely, politely some requests and I got no answer from the lead devs, and nothing granted, so 0 communication, and this at multiple times, this start pissing me off at a point I just think this engine should be deprecated. So I hope I will be heared and that a developer like s1lent will stop being "worthy of his name at being silent!", and take some time to perform some of our API requests, I do not think it's much asked... |
Hum, what do we need to do to get an answer or see our requests be considered? Tell me developers huh. Your support/communication is almost non-existent, that's pitiful, especially for such projects as much used. You really need to make more efforts about this. However, your projects just do not deserve to be as much used as they are, additionnaly to the fact you indirectly "refuse" to fix the major "shits & lacks" ReHLDS has compared to the GoldSrc engine. |
Hi. I've been an goldsrc modder in AMXX since 2009, been following this project since it's release and been using it while I see how it grows at every commit. @StevenKal I am aware of this request, and I agree on several points. Besides, I don't want to pressure devs to make something more than the whole project they already made and invested time on it. Actually I use ReHLDS and I cannot use ReGameDLL because I've been watching that some API request are just ignored by random people, and I need lots of functions to accomplish some modifications. It would be really helpful to have one attached topic to request API functions and hook chains. We're not obligated to use this (the whole RE project), that's enough reason to don't insist on something out of our laws. It's free and made with lot of patience, so the less thing we can do is be polite and respectful when it comes to ask and propose. Please consider the fact of expanding API functions by user requests and provide info about how to code modules using REHLDS API, because I don't know anything, not even an example, for C++ rookies. And I do not want to be rude with this, but @StevenKal was right when he said:
@s1lentq @WPMGPRoSToTeMa @theAsmodai (Note: most of the RE-related addons support is on russian forums only, there's still a huge community on the other side of the continent) |
Why haven't you done it yet? |
This seems weird, the fact you use ReHLDS, and not ReGameDLL_CS.
Yes, we are not obligated to use this and it's free, but devs bring it to us, exposed its assets, and, like most of the people, want us we use their stuff, because it's pleasant, however it's more likely a waste of time, but once we do, they provide a poor support with almost no communication when we need them (are they secret VALVe's employees? hihi!). Also, another important point, THEY choosen to "fuck up memory hacking possibilities" (something usually fully possible under the standard GoldSrc engine, & others like Svengine, Xash3D), we did not asked for such shit decision (no symbols researchable, hooks with parameters not hookable normally...), and all we got as info about this is "...This means that plugins that do binary code analysis (Orpheu for example) probably will not work with rehlds". I personnaly do not use ReHLDS on my public servers, the fact they fucked up memhack & refuse to answer me at least a single useful sentence, are two good reasons for me to do not use it.
I'm glad to see one more guy asking for this, as I did!
... then you might need to modify the major & minor versions required in the "mod_x_api.cpp" file depending on your needs (function/hook you need to use), to prevent non-loading of the Re* data when not necessary.
Exact, that's one more reason why they should make efforts here, to answer to other people not talking Russian, because we usually do not want to come on Russian-only forums post intruder English sentences among them!
Well, obviously we can do it, this does not cost anything, but if after that no dev having some access rights to the repository is O.K. to pin the topic to the head, and grant our requests, this is again, a bit useless... |
amxmod is not safe.. |
It's the bullshits of people like you, arkshine & other similar sheep & ignorants which are not safe to be listened... Toi, le geek qui semble avoir de l'intérêt pour divers trucs dans AMX qu'il n'y avait pas sous AMXX, s'arrange à refourger sa config AMXX (l'origine de la news AMXX est en partie de ta faute selon moi) sur un serveur utilisant AMX depuis belle lurette sans soucis et sur laquelle j'ai passé du temps, et balance en complément tes avis à la con. Moi je dis tu ferai mieux de fermer ta gueule du con. |
Is Windows safe to use, or Google, Facebook etc? They do the exact same thing. And when u consider that Windows is not free ... AMX is ok, nothing bad will happen if you use it. |
Hahahaha. Don't make people laugh. There are proofs that AMX Mod (without final X) isn't secure because developer tries to hide commands to became admin from any server using it. Well, the rest of the comments aren't new. Only @StevenKal trying to announce his AMX Mod with 'backdoor' code included. |
I also know a case where a friend's music files, he made some remixes, but, as you know, u can only use 20% of the song unless u get approval from the label, copyright. Guess what. He got a copyright claim from a label, and Microsoft removed not just that, but every single remix that he made completely from his PC. He was using using 7. Also, any version of Windows >= Vista has backdoor functions built-into by Microsoft. And if you have Windows 10, u can even login with your account on their website and see all the PC's connected to that account, their specs, HDD storage and possibly even the files. So imagine if a hacker somehow manages to get access to that account, what will he do? So what you're saying really makes no sense. Also, read about this: http://forums.joinsquad.com/topic/21464-nfo-servers-and-developers-backdoor/ This game is not free to play, yet the game creators created a developer access, which means that they can make themselves admins on any of the available game servers, and they can execute any commands, and what, did users complain about that? I guess not, but NFO decided to no longer support this game because of this access that the developers have given themselves on their game. Also, about Arkshine's post: It's been known for long that Arkshine wanted every single person on Earth that has a Half-Life engine-based server and uses custom plug-ins to use AMX Mod X. AdminMod has no developer access, and yet, Arkshine also criticized AdminMod, saying stuff like why use a bullshit program, lies about it and stuff. He was even trying to get all these developers to contribute to AMXX instead. And this is for sure of Arkshine's interest and is truly understandable. Because back then Arkshine had no job, all the money he got was from Allied Modders donations, and from 17buddies where he is also a moderator. I don't know how things changed since then, if he got a job, but it's in his interest to criticize every admin tool, being better or worse than AMXX. You see, the reason why AMXX supports ReHLDS is because of ReAMXX. If AMXX did not support Re, people would switch to ReAMXX, and that's truly what he wouldn't like to happen. Sure, it's also because ReAMXX was closed-source, but I'm quite sure that even if it had a source code available and was maintained on GitHub, he would still add all these features to AMXX just so people would not make the switch. |
All this doesn't make sense. You are just making offtopic. Stop, please. |
@DarthMan Ps: for the other who insults me in French, continue it shows your deep weakness. |
I see, but well, 99% of the companies are like that. That's why some people, at least I've a friend who switched to Ubuntu and now only uses free open-source apps and said to never ever buy a phone, if it doesn't come with Ubuntu or some other Linux distro for phones. He said he'd never touch iOs/Android/WP again, MS Office, Adobe apps and others. Steam, as well as the games that he likes are the only apps on his PC that could collect some user info, but that's because either these games can only be played through Steam and not without a game store app, or because these games are so cool and there are no alternatives. As I said, and I have proof from the guy who remixed the tracks, Microsoft also removed all of his mp3-saved remixes, as well as all of the FL project files for these remixes. And that without his approval, just because the music label gave a notice to Microsoft. But what if it wasn't the AMX dev, but instead it was someone else? |
Server Steam only. |
Goodbye @DarthMan 's excuses 🤣 |
But anyway, people must understand that it's not just AMX that has such features. Why don't people complain about Google, Facebook, WhatsApp, Yahoo!, Adobe and many, many more, that basically do the exact same thing. Do you remember what FaceApp did with user's profile pictures? That they were selling ads with your face if it looked fancy enough for them? Everybody's doing that, so if it is like that, it means everyone would have to switch to Linux distros, as Ubuntu, Linux Mint et cetera. I don't wanna start a war, I'm not against anyone, everyone's free to do what he thinks it's best for him. |
Yeah, the arkshine guy (AMXX's news author), the guy with the one I have a serious argue from years, the guy who distorted the truth about AMX a few times (and want to make believe the people that the truth about AMX is like he said, not like I say), the guy who told one day to the people that I had hacked a KRoT@L's forum account (while it was not true). @RauliTop: No, I have solid & important reasons to include it, you are just not "in my place" and you do not see/understand them, and it will probably never be removed. @GoRiLliAz: Like some other people (arkshine), you just do not deserve something else, that's all. By the way, the topic should probably be closed as this goes beyond its original issue (thanks the French shithead...), and I think we/I have also understand you devs, do not seem motivated at all at making some efforts to grant our API requests (sadly...), except when we do it ourselves via Pull Requests... |
Yeah. Do it. Also, you should provide an option to disable that feature. People must be awared about the features you add and the risks they can have. |
@DarthMan do you have rewritten BSP Compat plugin with ReAPI hookchain? If yes, please leave it in a comment. |
Someone with more experience with maps needs to test it
|
Hello. When trying to hook the function GetEntityInit on Linux ReHLDS, the server crashes with a segmentation fault. On Windows it all works fine. Same goes if using a HLDS linux server. It's just Linux ReHLDS where it's not working fine.
I also recommend adding more hooks to ReAPI if possible, and maybe integrating this function somewhere to be hookable, as it's quite useful. For example, joropito wrote a plug-in that makes use of this function. The main purpose of it is to fix entities that are not valid in mods such as TFC, for example. Basically about making the maps compatible with custom mods.
https://forums.alliedmods.net/showthread.php?p=1647630
I also recommend that you add more hooks to ReHLDS (hookchains), such as Steam_GSBSecure to be able to determine if a server is VAC-secured or not.
Here I attach some code, the Orpheu module was used.
The text was updated successfully, but these errors were encountered: