Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add win-arm64 migrator #3194

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

baszalmstra
Copy link

@baszalmstra baszalmstra commented Nov 23, 2024

Description:

This adds a migrator to add win-arm64 builds. I mostly copied the OSXArm migrator. Im unfamiliar with the codebase so I welcome feedback!

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

conda-forge/conda-forge.github.io#1940

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 30 lines in your changes missing coverage. Please review.

Project coverage is 77.69%. Comparing base (98b66da) to head (04d4416).

Files with missing lines Patch % Lines
conda_forge_tick/migrators/arch.py 57.57% 28 Missing ⚠️
conda_forge_tick/make_migrators.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3194      +/-   ##
==========================================
- Coverage   77.77%   77.69%   -0.09%     
==========================================
  Files         124      124              
  Lines       13423    13506      +83     
==========================================
+ Hits        10440    10493      +53     
- Misses       2983     3013      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Let's add an additional test that runs the migrator on a feedstock and make sure the pinnings repo is setup properly. Then we should be able to merge!

conda_forge_tick/migrators/arch.py Show resolved Hide resolved
@baszalmstra
Copy link
Author

@beckermr Is there an example for one of the other arch migrators that I could copy?

@beckermr
Copy link
Contributor

Not specifically for an arch migration but there are good examples in tests/test_migrators.py.

@beckermr
Copy link
Contributor

/relock-conda

WinArm64(
graph=total_graph,
pr_limit=PR_LIMIT,
name="arm64 win addition",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No piggy back migrators?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure what a piggy back migrator is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at the piggy back migrators list in OSX Arm migrator. They do additional stuff other than rerendering.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you merge main into your pr, there is now a default set you can use with a function to instantiate them. See the other samples.

@baszalmstra
Copy link
Author

I have been trying to come up with a test but Im really struggling to grasp how to construct all the different objects at play. If someone has some time, I would love some help with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants