Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot didn't update the SHA #184

Closed
scottbelden opened this issue Jun 13, 2018 · 6 comments
Closed

Bot didn't update the SHA #184

scottbelden opened this issue Jun 13, 2018 · 6 comments

Comments

@scottbelden
Copy link

Firstly, just want to say that I really like the regro-autotick-bot. However, a recent PR it created only updated the version number and not the SHA which resulted in failures in those CI tests due to the mismatch.

You can see from some previous merged PRs that in the past it created the correct change, but this time it messed up for some reason.

I can easily fix this if it was just a one time fluke, but I wanted to post this in case there was some underlying issue that you should be aware of.

Once again, thanks for the bot!

@scopatz
Copy link
Contributor

scopatz commented Jun 13, 2018

Thanks for reporting @scottbelden! This definitely should have been picked up. @justcalamari can you take a look please? Thanks!

@justcalamari
Copy link
Contributor

This is happening because the url key is indented by 4 spaces instead of 2, which the bot doesn't look for after merging #163. Once #182 is finished I think this will be fixed.

@scopatz
Copy link
Contributor

scopatz commented Jun 13, 2018

OK sounds great

@scottbelden
Copy link
Author

Thanks. Once that is merged is there some way for me to get the bot to re-create a PR?

@justcalamari
Copy link
Contributor

@scottbelden I think the only way of doing this is to change the attributes the bot sees for fastavro so it thinks there is no PR open. This will cause the bot to update the recipe and PR again. Creating the PR should fail since a PR already exists for the branch, but the changes will be pushed. I can do this once #182 goes in.

@justcalamari
Copy link
Contributor

It looks like this was fixed, so I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants