Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upgrade script callbacks - not to be used #3

Merged

Conversation

ethanfrey
Copy link

Remove all upgrade scripts callbacks from the upgrade module, as we no longer use them, and use the upgrade manager instead

@ethanfrey ethanfrey requested a review from aaronc August 27, 2019 11:46
@aaronc
Copy link
Member

aaronc commented Aug 27, 2019

I agree that we should remove the default script behavior.

I still think it would be useful to allow an OnUpgrade callback, that by default isn't set. It's not too hard and there might be uses for that which we can't foresee yet. What do you think?

@ethanfrey
Copy link
Author

"Cases we don't forsee" are dangerous.
They lead to over-engineered software.

If there is a clear need, do it.
If not, we add the feature when it is needed.

The feature didn't work reliably to swap out binaries, so we go with the upgrade manager. Let's stick with one way and make it work well. Don't give people too much to shoot themselves in the foot with

@ethanfrey ethanfrey merged commit 497655c into regen-network/upgrade-module-v0.4 Aug 27, 2019
@ethanfrey ethanfrey deleted the frey/remove-upgrade-script branch August 27, 2019 13:23
@ethanfrey ethanfrey mentioned this pull request Aug 27, 2019
sahith-narahari pushed a commit that referenced this pull request Dec 16, 2019
clevinson pushed a commit that referenced this pull request Mar 26, 2021
* prevent upgrades if client is expired

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants