Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Encrypted Extensions #124

Closed
gaukas opened this issue Oct 12, 2022 · 2 comments · Fixed by #142
Closed

Implement Encrypted Extensions #124

gaukas opened this issue Oct 12, 2022 · 2 comments · Fixed by #142
Labels
enhancement Feature with low severity but good value

Comments

@gaukas
Copy link
Contributor

gaukas commented Oct 12, 2022

Also potentially of note: we did an implementation of encrypted extensions in our branch. I don't think I can do a PR to your codebase though without a good bit of thought put into how additional handshake messages should be integrated into this project. Right now, you have to scatter them throughout the tls codebase. We pretty much just ported in from the BoringSSL test runner, but I didn't port in server side or unit tests, so that would be needed on top of this.
ulixee@8d0f1c4

FYI: Google sites will reject uTLS without this implementation.

Originally posted by @blakebyrnes in #122 (comment)
@gaukas gaukas added the help wanted Calling for community PR/volunteer label Oct 12, 2022
@piercefreeman piercefreeman mentioned this issue Oct 20, 2022
Open
@gaukas
Copy link
Contributor Author

gaukas commented Oct 31, 2022 •
edited
Loading

@blakebyrnes Sorry for my slow response. After reading thru your commit I don't think it is necessarily a bad idea to merge your commit. In addition I will try to get this merged while cleaning it up by allowing custom handshake messages.

@gaukas
Copy link
Contributor Author

gaukas commented Nov 11, 2022

Addressed in #142.

@gaukas gaukas mentioned this issue Nov 12, 2022
Merged
@gaukas gaukas added enhancement Feature with low severity but good value and removed help wanted Calling for community PR/volunteer labels Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature with low severity but good value
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement ALPS extension
1 participant
@gaukas