Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when the extension is mistakenly enabled everywhere #7381

Closed
fregante opened this issue Jun 2, 2024 · 1 comment · Fixed by #7407
Closed

Warn when the extension is mistakenly enabled everywhere #7381

fregante opened this issue Jun 2, 2024 · 1 comment · Fixed by #7407
Assignees
Labels
help wanted meta Related to Refined GitHub itself small Issues that new contributors can pick up under discussion

Comments

@fregante
Copy link
Member

fregante commented Jun 2, 2024

Browsers occasionally push users to enable the extension on every domain and that will cause issues:

What can Refined GitHub do when this setup is detected?

Probably:

  • immediately self-revoke the permission
  • tell the user what to do next, either via alert() or by opening a new tab on the wiki
  • call permissions.request() on github.com, if the browser is Safari, because it starts without that permission and because at this point it probably won't prompt the user
@fregante fregante added help wanted meta Related to Refined GitHub itself under discussion small Issues that new contributors can pick up labels Jun 2, 2024
@fregante
Copy link
Member Author

fregante commented Jun 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted meta Related to Refined GitHub itself small Issues that new contributors can pick up under discussion
Development

Successfully merging a pull request may close this issue.

1 participant