Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename isActions #41

Closed
yakov116 opened this issue Sep 30, 2020 · 1 comment · Fixed by #42
Closed

Rename isActions #41

yakov116 opened this issue Sep 30, 2020 · 1 comment · Fixed by #42
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@yakov116
Copy link
Member

There are 2 kind of actions.

  1. Marketplace actions
  2. Repo Actions

isMarketplaceActions?

I think that isActions should be the repo one and have isMarketplaceActions as an addition

WDYT?

The current actions
https://github.com/fregante/github-url-detection/blob/0f8a4260f3f869c537b2e9f878ff2f712c4a363d/index.ts#L448-L453
@fregante
Copy link
Member

Totally. This should be named isMarketplaceAction (not s, it's just one)

You can deprecate isActions and add isRepositoryActions

@fregante fregante added bug Something isn't working help wanted Extra attention is needed labels Sep 30, 2020
@yakov116 yakov116 mentioned this issue Sep 30, 2020
Merged
@yakov116 yakov116 mentioned this issue Sep 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename isAction to isMarketplaceAction refined-github/github-url-detection
2 participants
@fregante @yakov116