Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: since we already use setuptools, let's remove the optional logic in setup.py #18113

Closed
jreback opened this issue Nov 4, 2017 · 4 comments · May be fixed by reef-technologies/pandas#4
Closed

BLD: since we already use setuptools, let's remove the optional logic in setup.py #18113

jreback opened this issue Nov 4, 2017 · 4 comments · May be fixed by reef-technologies/pandas#4
Labels
Build Library building on various platforms
Milestone
0.23.0

Comments

@jreback
Copy link
Contributor

jreback commented Nov 4, 2017

no need to have the branching in setup.py we always have setuptools available.
@jreback jreback added Build Library building on various platforms Difficulty Intermediate labels Nov 4, 2017
@jreback jreback added this to the 0.22.0 milestone Nov 4, 2017
@ghost
Copy link

ghost commented Nov 6, 2017

Besides cleaning up setup.py does something else should be done? Are there any caveats regarding pandas build process?

@jreback
Copy link
Contributor Author

jreback commented Nov 6, 2017

no i think this all that is needed; we do sufficient testing on building in the CI

@ghost ghost mentioned this issue Nov 7, 2017
Open
4 tasks
@ghost
Copy link

ghost commented Nov 7, 2017

@jreback Do you think we could have Build subsection in whatsnew docs for BLD related entries? Or do they fall under one of existing subsections?

@jbrockmendel
Copy link
Member

the try/except of import setuptools also includes import pkg_resources. Is it also always the case that we always have pkg_resources?

@jbrockmendel jbrockmendel mentioned this issue Nov 17, 2017
Closed
4 tasks
@gkonefal-reef gkonefal-reef mentioned this issue Nov 23, 2017
Closed
4 tasks
jreback pushed a commit to jreback/pandas that referenced this issue Dec 3, 2017
@gkonefal-reef @jreback
BLD: since we already use setuptools, let's remove the optional logic…
c6b88e1 
closes pandas-dev#18113

Author: Grzegorz Konefał <[email protected]>
Author: Krzysztof Chomski <[email protected]>

Closes pandas-dev#18448 from gkonefal-reef/GH18113 and squashes the following commits:

21cbe79 [Grzegorz Konefał] Comments applied
290b49c [Krzysztof Chomski] BLD: since we already use setuptools, let's remove the optional logic in setup.py (GH18113).
jreback pushed a commit to jreback/pandas that referenced this issue Dec 3, 2017
@gkonefal-reef @jreback
BLD: since we already use setuptools, let's remove the optional logic…
b55b816 
closes pandas-dev#18113

Author: Grzegorz Konefał <[email protected]>
Author: Krzysztof Chomski <[email protected]>

Closes pandas-dev#18448 from gkonefal-reef/GH18113 and squashes the following commits:

21cbe79 [Grzegorz Konefał] Comments applied
290b49c [Krzysztof Chomski] BLD: since we already use setuptools, let's remove the optional logic in setup.py (GH18113).
@jreback jreback closed this as completed in a9e4731 Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
0.23.0
2 participants
@jreback @jbrockmendel