Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated links in "Can I put functions, promises, or other non-serializable items in my store state?" #4435

Closed

Conversation

jshoung
Copy link
Contributor

@jshoung jshoung commented Nov 14, 2022


name: 📖 Updated Documentation Content
about: Remove outdated content in "Can I put functions, promises, or other non-serializable items in my store state?"

Checklist

What docs page is being added or updated?

  • Section: Can I put functions, promises, or other non-serializable items in my store state?
  • Page: Redux FAQ: Organizing State

For Updating Existing Content

What updates should be made to the page?

  • Remove links with outdated content, which can be confusing for new developers

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 34d9da0:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for redux-docs ready!

Name Link
🔨 Latest commit 34d9da0
🔍 Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/63725e16985c1f0008b9c3d7
😎 Deploy Preview https://deploy-preview-4435--redux-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@markerikson
Copy link
Contributor

Hmm. Just glancing at these titles, they at least seem accurate / relevant to the topic.

@jshoung
Copy link
Contributor Author

jshoung commented Nov 15, 2022

@markerikson I read all the links and kept the ones that didn't mention older APIs like connect or class components.

Did I misinterpret the suggestion in the original issue (#4421)? I took it to mean that linked articles/discussions should use React hooks or be agnostic about the version of React used.

Happy to adjust as necessary for future PRs!

@markerikson
Copy link
Contributor

Yeah, that's definitely the overall goal! But, in this case this particular question isn't even about React - it's about what's permissible to go into Redux state. The linked discussions are certainly very old, but at least for this question, still relevant.

Tell you what - let's skip making changes to this one question for now, but please keep going with the general process! And thank you for helping with this :)

@jshoung
Copy link
Contributor Author

jshoung commented Nov 16, 2022

That makes sense, thanks for the feedback! And I'm more than happy to help out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants