Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Configuring Your Store to new Real World Usage section #3820

Closed
wants to merge 1 commit into from

Conversation

emgoto
Copy link

@emgoto emgoto commented Jul 18, 2020

PR Type

Moves existing page

Checklist

What docs page is being added or updated?

  • Section:
    New Section - "Real World Usage"
  • Page:
    Moved page "Configuring Your Store" to this new "Real World Usage' section.

Issues

I updated the _redirects file too. Unfortunately I wasn't able to get this branch hosted on Netlify to test my changes - ran into some issues:

Different publish path detected, going to use the one specified in the Netlify configuration file: 'website/website/build' versus 'build' in the Netlify UI
...
Failed during stage 'building site': Deploy directory 'website/website/build' does not exist

I also couldn't get Docusaurus running locally, I switched to the latest version and killed node_modules, and that fixed my problem.

@netlify
Copy link

netlify bot commented Jul 18, 2020

Deploy preview for redux-docs ready!

Built with commit 1521cdb

https://deploy-preview-3820--redux-docs.netlify.app

@markerikson
Copy link
Contributor

Thanks, appreciate the PR.

That said, I feel like we ought to try to nail down a master plan of what's going to get moved where and what we want the final structure of this new section to look like before we actually pull the trigger on moving things.

Maybe we can discuss this over in #3596 ?

@emgoto
Copy link
Author

emgoto commented Jul 19, 2020

Ah, my bad! I assumed the list of checklist items were ready to go. I can close off this PR for now.

@emgoto emgoto closed this Jul 19, 2020
@markerikson
Copy link
Contributor

I'd kinda sketched out a general idea of things, but it's been a long time since I wrote that out. I just don't want to end up having to move the same pages 2-3 different times :)

I'm definitely happy to chat with you and figure out exactly what ought to get moved where.

@markerikson
Copy link
Contributor

@emgoto I'd still be happy to have you help figure out how we ought to organize the "Real World Usage" section - let me know if you're interested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants