-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update style-guide.md #3700
Update style-guide.md #3700
Conversation
Add detailed docs for reduxjs#3692
Deploy preview for redux-docs ready! Built with commit 6a0b6a1 |
Sweet, thanks! My one stylistic nitpick is that I'm generally trying to move our examples away from hardcoded constants and I briefly debated asking for a side-by-side comparison of implementing the same logic via both a "state-first" and "action-first" approach, but we can save that for a longer docs page. I want to keep the "Style Guide" page shorter and focused overall. |
I'd like to do that; how would you suggest I refactor my example with that in mind? |
Erm... that's a good question, really. Problem is, that's primarily a Totally fine with showing, say, "baby's first FSM abstraction" in the larger docs page (as well as the obvious mentions of the small and full XState libs as full-blown solutions in that page as well). |
* Update style-guide.md Add detailed docs for reduxjs#3692 * Update style-guide.md Former-commit-id: 2ce7391 Former-commit-id: 7d857cc
* Update style-guide.md Add detailed docs for reduxjs#3692 * Update style-guide.md Former-commit-id: 2ce7391 Former-commit-id: 7d857cc
* Update style-guide.md Add detailed docs for reduxjs#3692 * Update style-guide.md Former-commit-id: 2ce7391 Former-commit-id: 7d857cc
Add detailed docs for #3692
PR Type
Does this PR add a new page, or update an existing page?
Checklist
What docs page is being added or updated?
https://redux.js.org/style-guide/style-guide/#treat-reducers-as-state-machines
For Updating Existing Content
What updates should be made to the page?
Adding detailed explanation for "Treat Reducers as State Machines"
Do these updates change any of the assumptions or target audience? If so, how do they change?
No