Fixed code style to match airbnb eslint #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export composeMiddleware from './utils/composeMiddleware'; | ||
| export composeStores from './utils/composeStores'; | ||
| export bindActionCreators from './utils/bindActionCreators'; | ||
| import composeMiddleware from './utils/composeMiddleware'; |
There was a problem hiding this comment.
eslint was complaining about the import and export in the same statement. I had to split it up.
There was a problem hiding this comment.
Keep babel-eslint and everything should be fine.
|
Hmm. I fixed it here #121 yesterday. Why did you duplicate my PR? |
| "env": { | ||
| "browser": true, | ||
| "mocha": true, | ||
| "node": true | ||
| }, | ||
| "parser": "babel-eslint", |
There was a problem hiding this comment.
Isn't it already defined here ?
|
@DenisIzmaylov I thought you were just submitting an ignore of all rules. You just changed your pull request a couple of hours ago. Since you started working on this, I will close this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#97 This changes style to match airbnb style guide. There were a couple of code changes to make this work. All the tests are passing.
It seems the eslint does not fully support decorators. I had to disable the padding rule in 2 tests.