Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Airbnb style in the source #97

Closed
gaearon opened this issue Jun 15, 2015 · 9 comments
Closed

Use the Airbnb style in the source #97

gaearon opened this issue Jun 15, 2015 · 9 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Jun 15, 2015

Following @DenisIzmaylov's suggestion in #95, I propose we adopt the Airbnb styleguide and change the style if it differs from Airbnb.

If everyone's on board with this, I'd accept a PR that:

  • adds as many Airbnb-enforcing style rules to .eslintrc as possible
  • changes the source and the README to match the styleguide

Thoughts?

@emmenko
Copy link
Contributor

emmenko commented Jun 15, 2015

@gaearon
Copy link
Contributor Author

gaearon commented Jun 15, 2015

I guess we can

@hzoo
Copy link

hzoo commented Jun 16, 2015

So you want to extend their rules? "extends": "eslint-config-airbnb",

You can also use the jscs autofix feature to fix most of the whitespace rules
jscs docs examples scripts src test --preset=airbnb --fix.
Can probably do a PR later for that.

@DenisIzmaylov
Copy link
Contributor

I'm agreed to @hzoo about eslint-config-airbnb. Yesterday I had tested "extends" feature of ESLint and it wasn't successful. Now I found that I used old (0.20) version which may not support this feature correctly. I will try with latest (0.23).

@DenisIzmaylov
Copy link
Contributor

Ok, in 0.23 it's working nice. But might be we have to upgrade some rules?

@DenisIzmaylov
Copy link
Contributor

Finished by PR #121

@ooflorent
Copy link
Contributor

Can we close it now?

@DenisIzmaylov
Copy link
Contributor

I think no. We have to update README examples to match this code style (point #2 from this issue).

@gaearon
Copy link
Contributor Author

gaearon commented Jun 20, 2015

I'd say let's close because README is going to be rewritten anyway.

@gaearon gaearon closed this as completed Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants