Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support including in rollup projects without extra plugins/hacks #3073

Closed
rjcorwin opened this issue Jul 25, 2018 · 1 comment
Closed

Support including in rollup projects without extra plugins/hacks #3073

rjcorwin opened this issue Jul 25, 2018 · 1 comment

Comments

@rjcorwin
Copy link

What is the current behavior?

Doing import { createStore } from 'redux' in a rollup project results in console error in browserredux.js:615 Uncaught ReferenceError: process is not defined.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar.

https://polymer-with-redux.glitch.me/

What is the expected behavior?

To not crash and not have to do any of the work arounds described in this rollup issue because sometimes we're in a situation where we can't / don't want to mess with rollup as is the case in a Polymer CLI project (related issue)

Which versions of Redux, and which browser and OS are affected by this issue? Did this work in previous versions of Redux?
Redux 4.0.0. I'm just testing in latest Chrome but I'm sure we'll see this everywhere. I'm not sure if it worked in previous versions of Redux.

@timdorr
Copy link
Member

timdorr commented Jul 25, 2018

Dupe of #2907

@timdorr timdorr closed this as completed Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants