-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta-question: Onboarding through documentation #2637
Comments
Yeah, the big issue here is that for very valid historical reasons, we have three separate libraries, each with their own repos:
Because of this, we also have three distinct docs sites:
Each of those docs sites is built out of content in their respective repos. The RTK docs did have a set of "basic/intermediate/advanced" tutorial pages in 2019. However, when I rewrote the Redux core docs tutorials in 2020, I realized that A) the new tutorials were much better, and B) having duplicated tutorial content was confusing. So, the approach I settled on was that all the actual "tutorial" content would go in the core docs site, along with the general-purpose usage guides (testing, thunks/selectors, etc). API docs and usage guides for the specific libraries would stay in their separate repos / docs sites. I've thought about the idea of consolidating all the docs into one large site. There are some potential benefits to doing so, including only having one place to find things. BUT... in order to do that, we'd almost definitely have to merge all three libraries into a single merged monorepo. That would be a massive undertaking. We'd have to:
To be honest, we simply don't have time for any of that. The Redux team is basically 2.75 people at this point: me, @phryneas , part of @msutkowski's time, and @timdorr quietly keeping an eye on things in the background. We've all got full-time jobs, and actual lives beyond that. (well. sorta, anyway :) ) As it is, the current main focus of getting RTK 1.9 out the door has been taking months. Lenz hasn't had much time recently, and I've managed to put in a few focused evenings to pick off some tasks, but that's taking way longer than I wanted it to. And after that, we want to work on RTK 2.0. So, even if we wanted to drastically revamp the repo and docs structure, we don't have the hundreds or thousands of hours of effort available to do that. Given that, the current docs sites structure is going to stay for the foreseeable future. I agree that there can be some confusion due to the multiple sites and different locations for some of the info, but this is the best we can do atm. |
I am actively working on conjuring time. |
Appreciate the quick responses. That totally makes sense - I'll contain future PRs to RTK as much as possible. The only (unsolicited) suggestion I'd have is to replicate the RTK link (found in Getting Started with Redux - Installation, for example) on more pages and/or move it to a persistent banner/button. As it stands now, it's really easy for newcomers to miss it, and go down the rabbit hole of parsing the Core docs before it's truly necessary. To be clear, I'm not expecting the main team to shift gears and start working on my pet peeves. But if this approach has your blessing(s), I'd include this in my own personal roadmap for contributions. It's too large of a suggestion to include in a single PR, so I figured I'd float the idea here. Honestly, using RTK has been a real joy, so I'd be glad to PR + help smooth over any onboarding bumps for newcomers |
Hmm. I'm actually not quite sure what the "RTK link" suggestion is, or what you mean by "the rabbit hole of parsing the core docs". Can you clarify that? The ideal sequence is that learners should go straight to the "Essentials" tutorial and go through it start to finish. Alternately, go through "Fundamentals" and then "Essentials". We've also got the couple "Quick Start" pages for people who just want "give me a couple quick examples and I'll figure things out from there". |
Related issue for linking purposes: reduxjs/redux#3958 |
Pasting some feedback from Discord:
also seems like lack of clarity around there being separate docs sites contributed to the confusion:
|
A few other folks have recently complained that having multiple docs sites with partially overlapping and partially exclusive content can be confusing. (Especially folks who end up on I've done a bit of research, and it seems like it might be technically feasible to have one giant merged docs site that is built out of content from all 3 repos, which would involve cloning the RTK and RR repos into the Redux core docs build step. There's a lot of potential technical complexity here:
This is still a very low priority for me given all the other things we've got going on. Updating the tutorials and working on RTKQ features is still much more important. But I can at least envision a hypothetical way to build a combined site technically that wouldn't involve having to merge all 3 repos into a monorepo. |
Happy to see this thread continue to get attention - thanks for caring about this @markerikson Just the other day, I was onboarding a team to RTK. Knowing “how” to read the docs played a huge part in communicating its value, especially compared to other state management tools that have cropped up recently. So there’s definitely still a need for this even if it isn't high priority. As always, let me know how I (and anyone else, for that matter) can pitch in! |
@greebl3 yeah, if you or others have examples of specific issues with the current organization and/or suggestions on how to improve them, I'm definitely interested! The most immediate thing would be someone putting together a working technical proof of concept for a merged docs build. The very first viability step would be a POC that shows pulling in one existing page from both the RTK and React-Redux docs, regardless of how those pages get organized or included. (In other words, I'm not looking for an ideal navigation layout or any permanent decision - just do something that involves cloning the other repos during the build step and including one piece of their content in the final core docs site). fwiw @riqts has also expressed an interest in trying to help with that, but I'd be happy to see dueling PRs to get a sense of what's possible :) |
Hi,
Curious what the team's stance is re: maintaining different domains and knowledge bases for Core vs RTK.
Given how hard the maintainers have been advocating for RTK usage, even for non-noobs, do you have any plans on folding the RTK docs into the main Redux docs (which I imagine is what most users land on first).
Seeing threads like this makes it clear that the Redux team has thought closely about the developer experience, especially for first-time users, so any clarity on this from a high-level would be appreciated as it would help me (and I'm sure many others) contextualize future PRs.
Pinging @markerikson specifically since he seems to be spearheading a lot of these docs-rewrite initiatives
The text was updated successfully, but these errors were encountered: