Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid confusion with Promises #1

Closed
gaearon opened this issue Sep 6, 2015 · 3 comments
Closed

Avoid confusion with Promises #1

gaearon opened this issue Sep 6, 2015 · 3 comments

Comments

@gaearon
Copy link

gaearon commented Sep 6, 2015

I think it's important to rename then() to something else. There was a lot of pain involved in establishing Promises A+ and implementations that chose to name their non-Promise thing then() made everyone unhappy.

@ashaffer
Copy link
Member

ashaffer commented Sep 6, 2015

I'm not opposed to that idea. I mostly named it that way so that it would be familiar to people

Some alternatives I can think of are when and bind (i.e. haskell's term - though this is overloaded in JS as well unfortunately).

Do you have any ideas/preference?

@gaearon
Copy link
Author

gaearon commented Sep 6, 2015

I mostly named it that way so that it would be familiar to people

That's the problem: something that is familiar but acts unfamiliar is going to cause trouble, just like it did in jQuery's unfortunate case. I'd probably call it .attach() or .step(). It's mutative right?

@ashaffer
Copy link
Member

ashaffer commented Sep 6, 2015

Yes it is mutative. .step() seems ok to me, i'll change it to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants