Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberFormat does not work as described #728

Open
edwardwoodward opened this issue Oct 18, 2016 · 1 comment
Open

NumberFormat does not work as described #728

edwardwoodward opened this issue Oct 18, 2016 · 1 comment
Assignees

Comments

@edwardwoodward
Copy link

  1. I have set property name="ignore_years" value="true"/ in NumberFormat, but it is still flagging "1990".
  2. The English description says that NumberFormat checks that numbers "don’t have excessive decimal points" but the Japanese description does not mention this:
    a) Does it check?
    b) If so, does it mean the number of points or the number of places after the point?
    c) Is there a property for specifying the number of places/points allowed?
  3. Please confirm: If "decimal_delimiter_is_comma" is set to true, does this mean that the decimal point is assumed to be a comma and the 3-digit delimiter for integers is assumed to be a period?
@ocadaruma
Copy link
Member

  1. I cannot reproduce the issue. Could you give the full-text ?
  • a) It checks. I will fix the Japanese description.
  • b) It means number of points.
  • c) Currently, there is no property for specifying number of points allowed.
  1. If "decimal_delimiter_is_comma" is set to true, the decimal point is assumed to be a comma but 3-digit delimiter is unaffected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants