From 432f51bc7bfdc4948e62fffeac20b6665ea1f8d5 Mon Sep 17 00:00:00 2001
From: Rafal Korepta <rafal.korepta@gmail.com>
Date: Fri, 15 Nov 2024 11:39:44 +0100
Subject: [PATCH] Upload kuttl-report.xml regardless of failure

In the successful CI run the `Parse Operator v2 Helm Test Results` buildkite
step failed due to missing kuttl-report.xml artifact from `K8s Operator v2 Helm`
step.

https://buildkite.com/redpanda/redpanda-operator/builds/3278#01932e57-1e35-4959-8aa8-241d60a4fc55/337-338

```
junit: Download the junits
INFO Searching for artifacts: "operator/tests/_e2e_artifacts_v2/kuttl-report.xml"
fatal: failed to download artifacts: No artifacts found for downloading
:boom: Could not download artifacts
```
---
 taskfiles/ci.yml | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/taskfiles/ci.yml b/taskfiles/ci.yml
index c8786e93b..8267e09e2 100644
--- a/taskfiles/ci.yml
+++ b/taskfiles/ci.yml
@@ -15,7 +15,7 @@ tasks:
 
   run-kuttl-tests:
     cmds:
-      - defer: 'task ci:kuttl-artifact-upload EXIT_CODE={{.EXIT_CODE}} KUTTL_CONFIG_FILE={{.KUTTL_CONFIG_FILE}}'
+      - defer: 'task ci:kuttl-artifact-upload KUTTL_CONFIG_FILE={{.KUTTL_CONFIG_FILE}}'
       - task: :k8s:run-kuttl-tests
         vars:
           KUTTL_CONFIG_FILE: '{{.KUTTL_CONFIG_FILE}}'
@@ -24,7 +24,7 @@ tasks:
     desc: uploads artifact when kuttl fails
     dir: operator
     summary: |
-      kuttl-artifact-upload should be called in `defer` with EXIT_CODE.
+      kuttl-artifact-upload should be called in `defer`.
       https://taskfile.dev/usage/#doing-task-cleanup-with-defer
       
       As buildkite pipeline step are wrapped with shell script, that executes
@@ -38,12 +38,9 @@ tasks:
         sh: |
           cat {{.KUTTL_CONFIG_FILE}} | grep artifactsDir | awk '{print $2}'
     cmds:
-      - echo "Kuttl returned exit code {{.EXIT_CODE}}. Creating artifacts tarball"
       - tar -czf {{.KUTTL_ARTIFACTS_DIR | base}}.tar.gz {{.KUTTL_ARTIFACTS_DIR}}
       - buildkite-agent artifact upload "{{.SRC_DIR}}/operator/{{.KUTTL_ARTIFACTS_DIR | base}}.tar.gz"
       - buildkite-agent artifact upload "{{.SRC_DIR}}/operator/{{.KUTTL_ARTIFACTS_DIR}}/kuttl-report.xml"
-    status:
-      - exit {{.EXIT_CODE}}
 
   k8s:
     cmds: