Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced logging for --show-diffs #118

Closed
samongyr-sq opened this issue Jun 21, 2023 · 1 comment
Closed

Enhanced logging for --show-diffs #118

samongyr-sq opened this issue Jun 21, 2023 · 1 comment
Labels
bug Something isn't working released Issue has been released

Comments

@samongyr-sq
Copy link

When using the replicate command with --mode compare and --show-diffs enabled, the output should contain more information about the mismatches found during validation

$ riot <source> replicate <target> --mode compare --show-diffs
Comparing 100% │███████████████████████│ 27/27 (0:00:01 / 0:00:00) 27.0/s >1 T0 ≠1 ⧗0

Additionally, when running the command with -i, sometimes the output will contain specific information about validation errors.

$ riot -i <source> replicate <target> --mode compare --show-diffs
18:37:02.382 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher	: Job: [SimpleJob: [name=compare-job]] launched with the following parameters: [{}]
18:37:02.406 INFO org.springframework.batch.core.job.SimpleStepHandler	: Executing step: [compare-step]
Comparing   0% │                                                                                                                                                           │ 0/7 (0:00:00 / ?) ?/s
18:37:03.849 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher	: Job: [SimpleJob: [name=compare-step-reader]] launched with the following parameters: [{}]
18:37:03.856 INFO org.springframework.batch.core.job.SimpleStepHandler	: Executing step: [compare-step-reader-step]
18:37:05.428 INFO org.springframework.batch.core.step.AbstractStep	: Step: [compare-step-reader-step] executed in 1s572ms
18:37:05.435 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher	: Job: [SimpleJob: [name=compare-step-reader]] completed with the following parameters: [{}] and the following status: [COMPLETED] in 1s583ms
18:37:05.533 WARNING com.redis.riot.cli.Replicate	: Value mismatch for string ods_stethoscope_heartbeat at offset 14
Comparing 100% │█████████████████████████████│ 27/27 (0:00:01 / 0:00:00) 27.0/s >1 T0 ≠1 ⧗0
18:37:05.855 WARNING com.redis.riot.cli.common.KeyComparisonStepListener	: Verification failed: OK=25 Missing=1 Values=1 TTLs=0 Types=0
18:37:05.857 INFO org.springframework.batch.core.step.AbstractStep	: Step: [compare-step] executed in 3s450ms
18:37:05.861 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher	: Job: [SimpleJob: [name=compare-job]] completed with the following parameters: [{}] and the following status: [COMPLETED] in 3s462ms

But other times the information seems to be omitted. It is not clear why this happens.

$ riot -i <source> replicate <target> --mode compare --show-diffs
18:48:26.265 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher	: Job: [SimpleJob: [name=compare-job]] launched with the following parameters: [{}]
18:48:26.289 INFO org.springframework.batch.core.job.SimpleStepHandler	: Executing step: [compare-step]
Comparing   0% │                                                                                                                                                           │ 0/7 (0:00:00 / ?) ?/s
18:48:27.651 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher	: Job: [SimpleJob: [name=compare-step-reader]] launched with the following parameters: [{}]
18:48:27.657 INFO org.springframework.batch.core.job.SimpleStepHandler	: Executing step: [compare-step-reader-step]
18:48:29.233 INFO org.springframework.batch.core.step.AbstractStep	: Step: [compare-step-reader-step] executed in 1s576ms
18:48:29.239 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher	: Job: [SimpleJob: [name=compare-step-reader]] completed with the following parameters: [{}] and the following status: [COMPLETED] in 1s585ms
Comparing 100% │█████████████████████████████│ 26/26 (0:00:01 / 0:00:00) 26.0/s >0 T0 ≠1 ⧗0
18:48:29.654 WARNING com.redis.riot.cli.common.KeyComparisonStepListener	: Verification failed: OK=25 Missing=0 Values=1 TTLs=0 Types=0
18:48:29.655 INFO org.springframework.batch.core.step.AbstractStep	: Step: [compare-step] executed in 3s366ms
18:48:29.659 INFO org.springframework.batch.core.launch.support.SimpleJobLauncher	: Job: [SimpleJob: [name=compare-job]] completed with the following parameters: [{}] and the following status: [COMPLETED] in 3s379ms
@jruaux jruaux added the bug Something isn't working label Jun 30, 2023
@jruaux jruaux closed this as completed in 87a82c1 Jun 30, 2023
@jruaux jruaux added the released Issue has been released label Jul 3, 2023
@jruaux
Copy link
Collaborator

jruaux commented Jul 3, 2023

🎉 This issue has been resolved in v3.1.1 (Release Notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Issue has been released
Projects
None yet
Development

No branches or pull requests

2 participants