Removed Lombok annotations from DataGenerator. Fixes #59

redis · Jun 22, 2021 · 9a83de3 · 9a83de3
1 parent 8c6a196
commit 9a83de3
Show file tree

Hide file tree

Showing 3 changed files with 63 additions and 32 deletions.
diff --git a/connectors/riot-db/src/test/java/com/redislabs/riot/db/TestPostgreSQL.java b/connectors/riot-db/src/test/java/com/redislabs/riot/db/TestPostgreSQL.java
@@ -3,7 +3,6 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.ObjectReader;
 import com.redislabs.riot.DataType;
-import com.redislabs.testcontainers.RedisContainer;
 import com.redislabs.testcontainers.RedisServer;
 import io.lettuce.core.api.sync.RedisHashCommands;
 import io.lettuce.core.api.sync.RedisKeyCommands;
@@ -30,7 +29,6 @@
 import java.sql.Statement;
 import java.time.LocalDate;
 import java.time.format.DateTimeFormatter;
-import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 
@@ -70,7 +68,7 @@ public void testExport(RedisServer container) throws Exception {
         Statement statement = connection.createStatement();
         statement.execute("CREATE TABLE mytable (id smallint NOT NULL, field1 bpchar, field2 bpchar)");
         statement.execute("ALTER TABLE ONLY mytable ADD CONSTRAINT pk_mytable PRIMARY KEY (id)");
-        dataGenerator(container).dataTypes(Collections.singletonList(DataType.HASH)).build().call();
+        dataGenerator(container).dataTypes(DataType.HASH).build().call();
         execute("export-postgresql", container, r -> configureExportCommand(r, POSTGRESQL));
         statement.execute("SELECT COUNT(*) AS count FROM mytable");
         ResultSet countResultSet = statement.getResultSet();

diff --git a/core/riot-test/src/main/java/com/redislabs/riot/AbstractRiotIntegrationTest.java b/core/riot-test/src/main/java/com/redislabs/riot/AbstractRiotIntegrationTest.java
@@ -116,7 +116,7 @@ protected static <C extends StatefulConnection<String, String>> GenericObjectPoo
     }
 
     protected DataGenerator.DataGeneratorBuilder dataGenerator(RedisServer container) {
-        return DataGenerator.builder(connection(container));
+        return DataGenerator.connection(connection(container));
     }
 
 

diff --git a/core/riot-test/src/main/java/com/redislabs/riot/DataGenerator.java b/core/riot-test/src/main/java/com/redislabs/riot/DataGenerator.java
@@ -6,44 +6,81 @@
 import io.lettuce.core.api.StatefulRedisConnection;
 import io.lettuce.core.api.async.*;
 import io.lettuce.core.cluster.api.StatefulRedisClusterConnection;
-import lombok.Builder;
-import lombok.Singular;
 import lombok.extern.slf4j.Slf4j;
 
 import java.util.*;
 import java.util.concurrent.Callable;
 import java.util.concurrent.TimeUnit;
 
 @Slf4j
-@Builder
 public class DataGenerator implements Callable<Long> {
 
-    private static final int DEFAULT_START = 0;
-    private static final int DEFAULT_END = 1000;
-    private static final boolean DEFAULT_EXPIRE = true;
-    private static final int DEFAULT_BATCH_SIZE = 50;
-    private static final int DEFAULT_MAX_EXPIRE = 100000;
-
     private final StatefulConnection<String, String> connection;
-    @Builder.Default
-    private final int start = DEFAULT_START;
-    @Builder.Default
-    private final int end = DEFAULT_END;
+    private final int start;
+    private final int end;
     private final long sleep;
-    @Builder.Default
-    private final int maxExpire = DEFAULT_MAX_EXPIRE;
-    @Builder.Default
-    private final int batchSize = DEFAULT_BATCH_SIZE;
-    @Singular
+    private final int maxExpire;
+    private final int batchSize;
     private final Set<DataType> dataTypes;
 
-    @SuppressWarnings("unused")
-    private static DataGeneratorBuilder builder() {
-        throw new IllegalArgumentException("builder() method is private");
+    public DataGenerator(StatefulConnection<String, String> connection, int start, int end, long sleep, int maxExpire, int batchSize, Set<DataType> dataTypes) {
+        this.connection = connection;
+        this.start = start;
+        this.end = end;
+        this.sleep = sleep;
+        this.maxExpire = maxExpire;
+        this.batchSize = batchSize;
+        this.dataTypes = dataTypes;
+    }
+
+    public static DataGeneratorBuilder connection(StatefulConnection<String,String> connection) {
+        return new DataGeneratorBuilder(connection);
     }
 
-    public static DataGeneratorBuilder builder(StatefulConnection<String,String> connection) {
-        return new DataGeneratorBuilder().connection(connection);
+    public static class DataGeneratorBuilder {
+
+        private static final int DEFAULT_START = 0;
+        private static final int DEFAULT_END = 1000;
+        private static final long DEFAULT_SLEEP = 0;
+        private static final int DEFAULT_BATCH_SIZE = 50;
+        private static final int DEFAULT_MAX_EXPIRE = 100000;
+
+        private final StatefulConnection<String, String> connection;
+        private int start = DEFAULT_START;
+        private int end = DEFAULT_END;
+        private long sleep = DEFAULT_SLEEP;
+        private int maxExpire = DEFAULT_MAX_EXPIRE;
+        private int batchSize = DEFAULT_BATCH_SIZE;
+        private Set<DataType> dataTypes = new HashSet<>(Arrays.asList(DataType.values()));
+
+        public DataGeneratorBuilder(StatefulConnection<String, String> connection) {
+            this.connection = connection;
+        }
+
+        public DataGenerator build() {
+            return new DataGenerator(connection, start, end, sleep, maxExpire, batchSize, dataTypes);
+        }
+
+        public DataGeneratorBuilder dataTypes(DataType... dataTypes) {
+            this.dataTypes = new HashSet<>(Arrays.asList(dataTypes));
+            return this;
+        }
+
+        public DataGeneratorBuilder start(int start) {
+            this.start = start;
+            return this;
+        }
+
+        public DataGeneratorBuilder end(int end) {
+            this.end = end;
+            return this;
+        }
+
+        public DataGeneratorBuilder sleep(long sleep) {
+            this.sleep = sleep;
+            return this;
+        }
+
     }
 
     @Override
@@ -133,11 +170,7 @@ private int flush() {
     }
 
     private boolean contains(DataType type) {
-        if (dataTypes.isEmpty()) {
-            return true;
-        }
         return dataTypes.contains(type);
     }
 
-
-}
+}
-Original file line number
+Diff line change
@@ Expand Up @@
         }
         protected DataGenerator.DataGeneratorBuilder dataGenerator(RedisServer container) {
-            return DataGenerator.builder(connection(container));
+            return DataGenerator.connection(connection(container));
         }
@@ Expand Down @@