Fix get # option in sort command #13608
Merged
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool, this bug just is introduced in 7.4, for old version, we don't support GET option in cluster mode, right? can you add some tests also, maybe just remove tag |
|
hi @ShooterIT , i'm not familiar with tcl test. maybe you can do it |
sundb
added
the
release-notes
|
Hi @opt-m I updated this PR, please have a look when you are available |
|
@ShooterIT I've reviewed the code, and everything looks great! |
sundb
changed the title
sundb
approved these changes
Oct 21, 2024
tezc
approved these changes
Oct 21, 2024
|
merged, thank you @opt-m |
|
Hi @sundb @YaacovHazan maybe we need to cherry pick it to 7.4 |
agree, i marked the backport label for 7.4. |
YaacovHazan
pushed a commit
that referenced
this pull request
Nov 4, 2024
From 7.4, Redis allows `GET` options in cluster mode when the pattern maps to the same slot as the key, but GET # pattern that represents key itself is missed. This commit resolves it, bug report #13607. --------- Co-authored-by: Yuan Wang <[email protected]>
Closed
YaacovHazan
pushed a commit
to YaacovHazan/redis
that referenced
this pull request
Nov 4, 2024
From 7.4, Redis allows `GET` options in cluster mode when the pattern maps to the same slot as the key, but GET # pattern that represents key itself is missed. This commit resolves it, bug report redis#13607. --------- Co-authored-by: Yuan Wang <[email protected]>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From 7.4, Redis allows
GEToptions in cluster mode when the pattern maps tothe same slot as the key, but GET # pattern that represents key itself is missed.
This commit resolves it.
fix #13607.