Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis-py ssl support susceptible to MITM attacks by default #1016

Closed
u2mejc opened this issue Aug 7, 2018 · 0 comments · Fixed by #1017
Closed

redis-py ssl support susceptible to MITM attacks by default #1016

u2mejc opened this issue Aug 7, 2018 · 0 comments · Fixed by #1017

Comments

@u2mejc
Copy link
Contributor

u2mejc commented Aug 7, 2018

Issue: redis-py doesn't enforce hostname validation (Common Name nor Subject Alternative Name) by default when accepting a cert from a remote SSL terminator. This default behavior isn't compatible to accepted PEPs/RFCs and provides a dangerous sense of false security.

Task: Correct redis-py to validate certificates by default. IMHO this shouldn't be considered a breaking change as it simply reenforces the expected results when initiating a SSL connection.

Additional research:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant