Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json commands not exposed in AsyncCluster #3048 #3049

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Json commands not exposed in AsyncCluster #3048 #3049

merged 3 commits into from
Nov 8, 2024

Conversation

tishun
Copy link
Collaborator

@tishun tishun commented Nov 6, 2024 •
edited
Loading

Closes #3048

Added missing ASYNC and REACTIVE interfaces for the cluster commands
Added tests to verify the change works
Changed the way the testcontainers are being started

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@tishun tishun added this to the 6.5.1.RELEASE milestone Nov 6, 2024
@tishun tishun requested a review from ggivo November 6, 2024 16:32
@tishun tishun merged commit 345e0f9 into redis:main Nov 8, 2024
5 checks passed
@tishun tishun deleted the topic/tishun/issue-3048 branch November 8, 2024 09:50
tishun added a commit that referenced this pull request Dec 1, 2024
@tishun
Json commands not exposed in AsyncCluster #3048 (#3049)
f307d20 
* Added missing ASYNC and REACTIVE interfaces for the cluster commands

* Handle container start failures more gracefully

* Attempt to start the containers three times before failing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggivo ggivo Awaiting requested review from ggivo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5.1.RELEASE
Development

Successfully merging this pull request may close these issues.

Json commands not exposed in AsyncCluster
1 participant
@tishun