WATCH during MULTI shouldn't fail transaction #3009 #3027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3009
Problem statement
The submit attempts to solve two distinct issues existing in the driver currently:
WATCH
(WATCH
called after aMULTI
and before anEXEC
would result in some of the results in the TransactionResult to be missing, because the error result from theWATCH
would push them outWATCH
behaves differently than a nestedMULTI
, which instead throws an exception (but does not fail the transaction).In a broader context the Redis server seems to handle errors inside transactions in three different ways:
Proposed solution
Make both
WATCH
andMULTI
behave the same way when called inside a transaction:Benefits
MULTI
at all)Make sure that:
mvn formatter:format
target. Don’t submit any formatting related changes.