Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json commands not exposed in AsyncCluster #3048

Closed
yisraelU opened this issue Nov 5, 2024 · 1 comment · Fixed by #3049
Closed

Json commands not exposed in AsyncCluster #3048

yisraelU opened this issue Nov 5, 2024 · 1 comment · Fixed by #3049
Labels
type: bug A general bug
Milestone
6.5.1.RELEASE

Comments

@yisraelU
Copy link

yisraelU commented Nov 5, 2024 •
edited
Loading

Bug Report

I am using the latest release 6.5.0 which has the recently added redisJson commands (Thank you and Great Job!).

Using the StatefulRedisClusterConnection , I can access either RedisAdvancedClusterCommands which gives me access to RedisJsonCommands through the simple inheritance model.
However when using the async member RedisAdvancedClusterAsyncCommands , it would appear that the RedisJsonAsyncCommands was left out of RedisClusterAsyncCommands here

If this is intentional , what would the proper path forward be to access redisJson async commands for a cluster?
@tishun tishun added the type: bug A general bug label Nov 6, 2024
@tishun tishun added this to the 6.5.1.RELEASE milestone Nov 6, 2024
@tishun
Copy link
Collaborator

tishun commented Nov 6, 2024

Hey @yisraelU ,
thanks for the report, yeah, this is something we overlooked.

Will work to fix it ASAP

@tishun tishun mentioned this issue Nov 6, 2024
Merged
4 tasks
tishun added a commit that referenced this issue Nov 8, 2024
@tishun
Json commands not exposed in AsyncCluster #3048 (#3049)
345e0f9 
* Added missing ASYNC and REACTIVE interfaces for the cluster commands

* Handle container start failures more gracefully

* Attempt to start the containers three times before failing
tishun added a commit that referenced this issue Dec 1, 2024
@tishun
Json commands not exposed in AsyncCluster #3048 (#3049)
f307d20 
* Added missing ASYNC and REACTIVE interfaces for the cluster commands

* Handle container start failures more gracefully

* Attempt to start the containers three times before failing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
6.5.1.RELEASE
Development

Successfully merging a pull request may close this issue.

Json commands not exposed in AsyncCluster #3048 tishun/lettuce-core
2 participants
@yisraelU @tishun