From 3dbdbd9baa5affb7f4684b1033a58dd171ebb982 Mon Sep 17 00:00:00 2001
From: Mark Paluch <mpaluch@paluch.biz>
Date: Thu, 6 Jul 2023 12:39:08 +0200
Subject: [PATCH] Accept Double and Boolean in `MapOutput` #2429

---
 .../io/lettuce/core/output/MapOutput.java     | 26 +++++++
 .../core/output/MapOutputUnitTests.java       | 77 +++++++++++++++++++
 2 files changed, 103 insertions(+)
 create mode 100644 src/test/java/io/lettuce/core/output/MapOutputUnitTests.java

diff --git a/src/main/java/io/lettuce/core/output/MapOutput.java b/src/main/java/io/lettuce/core/output/MapOutput.java
index 0b57ef95aa..5b1d60a828 100644
--- a/src/main/java/io/lettuce/core/output/MapOutput.java
+++ b/src/main/java/io/lettuce/core/output/MapOutput.java
@@ -68,6 +68,32 @@ public void set(long integer) {
         key = null;
     }
 
+    @Override
+    public void set(double number) {
+
+        if (key == null) {
+            key = (K) Double.valueOf(number);
+            return;
+        }
+
+        V value = (V) Double.valueOf(number);
+        output.put(key, value);
+        key = null;
+    }
+
+    @Override
+    public void set(boolean flag) {
+
+        if (key == null) {
+            key = (K) Boolean.valueOf(flag);
+            return;
+        }
+
+        V value = (V) Boolean.valueOf(flag);
+        output.put(key, value);
+        key = null;
+    }
+
     @Override
     public void multi(int count) {
 
diff --git a/src/test/java/io/lettuce/core/output/MapOutputUnitTests.java b/src/test/java/io/lettuce/core/output/MapOutputUnitTests.java
new file mode 100644
index 0000000000..fec234e4c7
--- /dev/null
+++ b/src/test/java/io/lettuce/core/output/MapOutputUnitTests.java
@@ -0,0 +1,77 @@
+/*
+ * Copyright 2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.lettuce.core.output;
+
+import static org.assertj.core.api.Assertions.*;
+
+import java.nio.ByteBuffer;
+
+import org.junit.jupiter.api.Test;
+
+import io.lettuce.core.codec.StringCodec;
+
+/**
+ * Unit tests for {@link MapOutput}.
+ *
+ * @author Mark Paluch
+ */
+class MapOutputUnitTests {
+
+    @Test
+    void shouldAcceptValue() {
+
+        MapOutput<String, String> sut = new MapOutput<>(StringCodec.UTF8);
+        sut.multi(2);
+        sut.set(ByteBuffer.wrap("hello".getBytes()));
+        sut.set(ByteBuffer.wrap("world".getBytes()));
+
+        assertThat(sut.get()).containsEntry("hello", "world");
+    }
+
+    @Test
+    void shouldAcceptBoolean() {
+
+        MapOutput<String, Object> sut = new MapOutput(StringCodec.UTF8);
+        sut.multi(2);
+        sut.set(ByteBuffer.wrap("hello".getBytes()));
+        sut.set(true);
+
+        assertThat(sut.get()).containsEntry("hello", true);
+    }
+
+    @Test
+    void shouldAcceptDouble() {
+
+        MapOutput<String, Object> sut = new MapOutput(StringCodec.UTF8);
+        sut.multi(2);
+        sut.set(ByteBuffer.wrap("hello".getBytes()));
+        sut.set(1.2);
+
+        assertThat(sut.get()).containsEntry("hello", 1.2);
+    }
+
+    @Test
+    void shouldAcceptInteger() {
+
+        MapOutput<String, Object> sut = new MapOutput(StringCodec.UTF8);
+        sut.multi(2);
+        sut.set(ByteBuffer.wrap("hello".getBytes()));
+        sut.set(1L);
+
+        assertThat(sut.get()).containsEntry("hello", 1L);
+    }
+
+}