Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SslOptions #3980

Draft
wants to merge 35 commits into
base: master
Choose a base branch
from
Draft

Add SslOptions #3980

wants to merge 35 commits into from

Conversation

sazzad16
Copy link
Collaborator

Similar to SslOptions in Lettuce library.

Copy link
Contributor

@atakavci atakavci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having a trust manager like this smells off. May be its because i am lack of context. What is the rationale ?

@tishun
Copy link

tishun commented Oct 1, 2024

having a trust manager like this smells off. May be its because i am lack of context. What is the rationale ?

I have the same question. The motivation of the change is important in this case.

@uglide
Copy link
Contributor

uglide commented Oct 2, 2024

@tishun @atakavci This is an attempt to create a TLS config similar to what we have in Lettuce, as a more developer-friendly option compared to the current approach with SSLSocketFactory, etc.

@sazzad16
Copy link
Collaborator Author

sazzad16 commented Oct 2, 2024

having a trust manager like this smells off. May be its because i am lack of context. What is the rationale ?

I have the same question. The motivation of the change is important in this case.

@tishun

  1. Lettuce has similar support.
  2. Users want insecurity.

Copy link

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may not be getting the whole idea, so please excuse me if my comments are not making sense.

My current assumption is that we only want to be able to enable and disable hostname verification, as part of the SSL verification process.

src/main/java/redis/clients/jedis/SslOptions.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/SslOptions.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants