-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SslOptions #3980
base: master
Are you sure you want to change the base?
Add SslOptions #3980
Conversation
inspired by SslVerifyMode in Lettuce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having a trust manager like this smells off. May be its because i am lack of context. What is the rationale ?
src/main/java/redis/clients/jedis/DefaultJedisClientConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/DefaultJedisClientConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/DefaultJedisClientConfig.java
Outdated
Show resolved
Hide resolved
I have the same question. The motivation of the change is important in this case. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may not be getting the whole idea, so please excuse me if my comments are not making sense.
My current assumption is that we only want to be able to enable and disable hostname verification, as part of the SSL verification process.
src/main/java/redis/clients/jedis/DefaultJedisClientConfig.java
Outdated
Show resolved
Hide resolved
to avoid confusion at this moment.
does this reduce confusion?
src/main/java/redis/clients/jedis/util/InsecureTrustManagerFactory.java
Outdated
Show resolved
Hide resolved
and INSECURE option (renamed from NONE) is added back in SslVerifyMode.
and document as JavaDoc in JedisClientConfig
f80ccbb
to
06371b5
Compare
dcabe80
to
309d477
Compare
Similar to SslOptions in Lettuce library.