Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default MaxRetries on cluster clients is -1 and not 3 #2249

Open
jbeaudetupgrade opened this issue Oct 13, 2022 · 2 comments
Open

Default MaxRetries on cluster clients is -1 and not 3 #2249

jbeaudetupgrade opened this issue Oct 13, 2022 · 2 comments

Comments

@jbeaudetupgrade
Copy link

Expected Behavior

I believe the MaxRetries default value should be the same for clusters and standalone mode, unless it's intended?

Current Behavior

This commit added a specific disable to MaxRetries in ClusterOptions as opposed to Options which defaults to 3.

Possible Solution

If it's intended, we should add documentation in the code at least. If it's not, then it's a simple fix :)

Thanks

@vmihailenco
Copy link
Collaborator

vmihailenco commented Nov 17, 2022

That change was intentional. MaxRetries are disable, because the Cluster client handles all kind of retries.

We probably should explain this somewhere.

@bvdwalt
Copy link

bvdwalt commented Feb 19, 2023

I can take this and update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants