Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Debain base to stretch (fix #129) #143

Merged
merged 2 commits into from
Jun 19, 2018
Merged

Update Debain base to stretch (fix #129) #143

merged 2 commits into from
Jun 19, 2018
+32 −8

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Jun 9, 2018 •
edited by yosifkit
Loading

fixes #129

@yosifkit
Copy link
Contributor

Can we add the gpgconf --kill all too?

@J0WI
Copy link
Contributor Author

J0WI commented Jun 11, 2018

Sure. I planned to do this in a follow-up PR, but I can push it here if you prefer.

@yosifkit
Copy link
Contributor

Looks like the 32bit versions need the stretch update too 😉

@J0WI
Copy link
Contributor Author

J0WI commented Jun 11, 2018

Indeed. Would be great to have templates here btw. 😆

@tianon tianon merged commit 53f8680 into redis:master Jun 19, 2018
@J0WI J0WI deleted the stretch branch June 19, 2018 22:21
tianon added a commit to infosiftr/stackbrew that referenced this pull request Jun 20, 2018
@tianon
Update docker-library images
92586b4 
- `ghost`: 1.24.5
- `mariadb`: 10.1.34
- `mongo`: 4.0.0-rc6
- `php`: add `gpgconf --kill all` (docker-library/php#666)
- `redis`: stretch (redis/docker-library-redis#143)
- `redmine`: add back `imagemagick` (docker-library/redmine#121)
- `rocket.chat`: 0.65.2
@tianon tianon mentioned this pull request Jun 20, 2018
Merged
@laurieodgers
Copy link

Why was the underlying distro updated from 8 to 9? This has caused breaking changes on our production system

@tianon
Copy link
Contributor

tianon commented Jul 24, 2018 via email

@laurieodgers
Copy link

laurieodgers commented Jul 24, 2018 •
edited
Loading

We're running this in k8s with autoconfiguration of redis.conf in the entrypoint script. The ip of the container was retrieved using ifconfig eth0 | grep 'inet addr' | awk '{ print $2 }' | cut -d: -f2 which has now been changed to the safer hostname --ip-address. This ip is used for slave-announce-ip.

ifconfig output in debian 8:

eth0      Link encap:Ethernet  HWaddr 56:4a:18:b4:57:37
          inet addr:10.0.157.62  Bcast:0.0.0.0  Mask:255.255.255.255
          inet6 addr: fe80::544a:18ff:feb4:5737/64 Scope:Link
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:8616981 errors:0 dropped:0 overruns:0 frame:0
          TX packets:6699059 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:761079871 (725.8 MiB)  TX bytes:1291079302 (1.2 GiB)

ifconfig output in debian 9:

eth0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet 172.17.0.2  netmask 255.255.0.0  broadcast 0.0.0.0
        inet6 fe80::42:acff:fe11:2  prefixlen 64  scopeid 0x20<link>
        ether 02:42:ac:11:00:02  txqueuelen 0  (Ethernet)
        RX packets 6  bytes 508 (508.0 B)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 6  bytes 508 (508.0 B)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

Note the missing addr after inet in jessie 9. Its a minor change, but a breaking change.

@laurieodgers
Copy link

The tag we're using is 3.2. This could be mitigated in future with an appended distro name on the tag? ie 3.2-jessie 3.2-stretch?

@tianon tianon mentioned this pull request Jul 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider moving to stretch base image
4 participants
@J0WI @yosifkit @laurieodgers @tianon