Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for calico CNI #241

Merged
merged 1 commit into from
Jul 23, 2018
Merged

Add support for calico CNI #241

merged 1 commit into from
Jul 23, 2018

Conversation

fepan
Copy link
Contributor

@fepan fepan commented Jul 23, 2018

No description provided.

@ghost ghost assigned fepan Jul 23, 2018
@ghost ghost added the state:needs_review label Jul 23, 2018
@fepan fepan requested review from s1061123 and dougbtv July 23, 2018 02:16
Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Feng, thanks for the PR. Couple comments inbound regarding follow-up required to help support this in the future, but, OK to merge at any time (which I'll do after)

@dougbtv
Copy link
Member

dougbtv commented Jul 23, 2018

Threw in some references to issues that were uncovered and require some follow-up. Just for posterity's sake.

Looks good, merging it up! Thanks again.

@dougbtv dougbtv merged commit 8fe7139 into redhat-nfvpe:master Jul 23, 2018
@ghost ghost removed the state:needs_review label Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants