Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine support #986

Closed
cirolosapio opened this issue Apr 15, 2024 · 5 comments · Fixed by #991
Closed

Alpine support #986

cirolosapio opened this issue Apr 15, 2024 · 5 comments · Fixed by #991
Milestone

Comments

@cirolosapio
Copy link
Contributor

as eclipse/lemminx readme says:

On Linux, compile with ./mvnw clean package -Dnative -DskipTests -Dgraalvm.static=--static in order to support distributions that don't use glibc, such as Alpine Linux

is it possible to add an alpine build with the -Dgraalvm.static=--static ?

@cirolosapio
Copy link
Contributor Author

is there a released version of the vscode extension that use the compiled lemminx with that property?

@fbricon
Copy link
Collaborator

fbricon commented Apr 18, 2024

No there is not. We can't release 2 linux versions to the marketplace.
Ideally, the binary would be generated and stored as a release artifact in this repo, but our team is stretched too thin at the moment so we can't commit to address this issue anytime soon.

@rgrunber
Copy link
Member

rgrunber commented Apr 18, 2024

At first we had the static flag to support #457 . Then we realized in #597 (comment) that the flag broke for all other linux distros.

However, I just had a look at my old comment at #597 (comment) . VS Code does support alpine-x64. If all that's needed is a a static glibc, and if we can just use a GH Actions Ubuntu runner that simply has the static flag enabled, and package that into a vsix targeting alpine-x64, I think it could work.

But yeah, it adds yet another part to the build+release process.

@cirolosapio
Copy link
Contributor Author

something like this #989 ?

@rgrunber rgrunber linked a pull request Apr 23, 2024 that will close this issue
@fbricon
Copy link
Collaborator

fbricon commented Apr 24, 2024

Alpine extension is now available in the VS Code Marketplace as a pre-release

Screenshot 2024-04-24 at 12 48 59

As well as https://github.com/redhat-developer/vscode-xml/releases/tag/latest

@fbricon fbricon added this to the 0.27.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants