Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine "startup" & "server.initialized" telemetry events #818

Closed
rgrunber opened this issue Nov 22, 2022 · 1 comment · Fixed by #824
Closed

Combine "startup" & "server.initialized" telemetry events #818

rgrunber opened this issue Nov 22, 2022 · 1 comment · Fixed by #824
Assignees
Milestone

Comments

@rgrunber
Copy link
Member

If a user has opted-in, we send 2 events on startup of the extension. One purely from the client side, and one from the server side. It would be good to combine these into one. Maybe the "startup" event should wait for the "server.initialized" event, or something to that effect.

Main problem is that, if "server.initialized" fails, there's no server to send the event for failure, so "startup" shouldn't wait. Either some timeout, or a way for the client to check if the server failed.

@rgrunber
Copy link
Member Author

Maybe @JessicaJHee is interested in having a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants