Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After a tag is collapsed, the content of the entire tag cannot be deleted #690

Closed
jmu201621143028 opened this issue Apr 1, 2022 · 2 comments · Fixed by #714
Closed

After a tag is collapsed, the content of the entire tag cannot be deleted #690

jmu201621143028 opened this issue Apr 1, 2022 · 2 comments · Fixed by #714
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@jmu201621143028
Copy link

This function was normal before,I'm not sure if something was updated that is preventing it from working.
image
I hit the Backspace key
image
I was expecting to delete the content of the entire note tag

@fbricon
Copy link
Collaborator

fbricon commented Apr 1, 2022

mmm might be caused by #665, since folding now only displays the opening tag.

@angelozerr
Copy link
Contributor

angelozerr commented Apr 1, 2022

mmm might be caused by #665, since folding now only displays the opening tag.

Indeed it's the cause of this problem. I noticed that vscode doesn't support this usecase, see my comment at microsoft/vscode#3352 (comment)

By waiting for a fix from vscode, here several solutions:

  • keep like this and mention this limitation to the README
  • remove this unfold of last line
  • provide a settings for folding last line.

I think the last should be the better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants