Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document symbols limit warning keeps popping up on each change #243

Closed
fbricon opened this issue Apr 21, 2020 · 1 comment · Fixed by eclipse-lemminx/lemminx#656
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@fbricon
Copy link
Collaborator

fbricon commented Apr 21, 2020

Set "xml.symbols.maxItemsComputed": 3, for instance, open a pom.xml, on every keystroke, the limit warning pops up:
Screen Shot 2020-04-21 at 11 14 54 AM

@fbricon fbricon added the bug Something isn't working label Apr 21, 2020
@fbricon fbricon added this to the 0.12.0 milestone Apr 21, 2020
@angelozerr
Copy link
Contributor

angelozerr commented Apr 21, 2020

Indeed it misses the JSON part https://github.com/microsoft/vscode/blob/9f709d170b06e991502153f281ec3c012add2e42/extensions/json-language-features/server/src/jsonServerMain.ts#L204 which manages a cache of warning.

And I think we should have the same LimitExceededWarnings class because we will able to to use for other feature like folding, see
https://github.com/microsoft/vscode/blob/9f709d170b06e991502153f281ec3c012add2e42/extensions/json-language-features/server/src/jsonServerMain.ts#L500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants